"aws configure sso" fails unhelpfully with invalid SSO session names

[gbenson]

Describe the bug

aws configure sso fails with a cryptic error message if an invalid SSO session name is supplied.

Expected Behavior

It'd be nice to have an informative error message:

$ aws configure sso
SSO session name (Recommended): AWS on Chromebook

Error: "AWS on Chromebook" is not a valid session name (try "aws-on-chromebook" instead?)

Current Behavior

$ aws configure sso
SSO session name (Recommended): AWS on Chromebook
SSO start URL [None]: https://whatever.awsapps.com/start
SSO region [None]: us-east-1
SSO registration scopes [sso:account:access]:

An error occurred (InvalidClientMetadataException) when calling the RegisterClient operation:

There's nothing more, the command terminates there. Possibly a traceback got eaten somewhere?

Reproduction Steps

Run aws configure sso and give it an SSO session name with whitespace in it.

Possible Solution

No response

Additional Information/Context

No response

CLI version used

aws-cli/2.9.21

Environment details (OS name and version, etc.)

Python/3.9.11 Linux/5.10.153-20434-g98da1eb2cf9d exe/x86_64.debian.11 prompt/off

[tim-finnigan]

Thanks @gbenson for reporting this issue, I could reproduce the behavior you described. It looks like a client-side validator could be added here to ensure that the SSO Session Name doesn't contain spaces:

aws-cli/awscli/customizations/configure/sso.py

Lines 209 to 228 in dc53215

	def prompt_for_sso_session(self, required=True):
	prompt_text = 'SSO session name'
	prompt_fmt = None
	validator_cls = None
	if required:
	validator_cls = RequiredInputValidator
	if not self.sso_session:
	prompt_fmt = f'{prompt_text}: '
	if not required:
	prompt_fmt = f'{prompt_text} (Recommended): '
	sso_session = self._prompt_for(
	'sso_session', prompt_text,
	completions=sorted(self._sso_sessions),
	toolbar=self._get_sso_session_toolbar,
	validator_cls=validator_cls,
	prompt_fmt=prompt_fmt,
	current_value=self.sso_session,
	)
	self.sso_session = sso_session
	return sso_session

[tim-finnigan]

Upon revisiting this and testing again, it appears that the issue has since been fixed. Please update to a recent version (2.18.16 is the latest per the CHANGELOG) and let us know if you're still seeing any issues.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.