Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the type of properties in primaryIdentifier #98

Open
wbingli opened this issue Jul 8, 2020 · 2 comments
Open

Validate the type of properties in primaryIdentifier #98

wbingli opened this issue Jul 8, 2020 · 2 comments

Comments

@wbingli
Copy link
Contributor

wbingli commented Jul 8, 2020

Only String or Number type property can be primaryIdentifier. We should enforce it during schema validation.

@PatMyron
Copy link
Contributor

@wbingli related: see #87 for request for array type primaryIdentifiers

@benkehoe
Copy link

Should list-valued identifiers be allowed?

We're creating a resource provider for the sorely-needed S3 bucket notification resource. While the notifications have individual IDs, there is a constraint that no two notifications can overlap in prefix+events. So we had this idea of using that combination as an identifier.

This case is less of a list-valued identifier, and more of a set-valued constraint, but I wanted to raise the question for discussion if others had ideas about when a list-valued identifier would be useful. Given that the primary identifier itself can be list-valued, it seems plausible that sometimes the list wouldn't come from a series of scalar properties but from a single property containing that list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants