Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use getAwsPartition() once implemented #5

Open
xaoyuli opened this issue May 20, 2020 · 0 comments
Open

use getAwsPartition() once implemented #5

xaoyuli opened this issue May 20, 2020 · 0 comments

Comments

@xaoyuli
Copy link
Contributor

xaoyuli commented May 20, 2020

Both in pull request #4 #3, in Translator class, we hardcode the partition as "aws" in getArn fucntion.
Should use getAwsPartition() once implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xaoyuli