Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto complete #35

Closed
reblevins opened this issue Nov 6, 2020 · 10 comments
Closed

Auto complete #35

reblevins opened this issue Nov 6, 2020 · 10 comments
Assignees
Labels
bug Something isn't working upstream

Comments

@reblevins
Copy link

reblevins commented Nov 6, 2020

Hi,
First, thanks for this atom plugin, it's great.

I recently upgraded to version 1.4.0 and auto-complete is not working as expected.

Normally, when I begin typing, it displays a list of possibilities, I pick the one I want, hit enter or tab and it completes it for me. That part is working fine, however for some reason it is deleting the character right in front of where the cursor started.

Example:
I start typing:
this.someProp, someProperty shows in the list, I select it, then hit enter and it inserts someProperty, but removes the period.
So now it becomes thissomeProperty instead of what it should be is this.someProperty (notice the . is missing in the first one).

I'm fairly certain it is die to this package because when I disable this package, auto-complete works as expected.

Thanks again.

UPDATE:
When I am typing parentheses or brackets, it works fine. So (someProp... becomes (someProperty)

@phromo
Copy link

phromo commented Nov 6, 2020

Also just discovered this, I'm SO thrilled and happy that atom-ide-community are updating the atom-ide-ui package.

As reblevins writes: running completion on myobject.thing (ctrl-space, select item in list) makes the editor end up with "myobjectthing" (without dot). Tested in .vue and .ts files, using Atom 1.52.0 and atom-ide-vue 1.4.0, autocomplete-plus 2.42.3.

If someone can point me in the right direction maybe I can help out as well. Thanks!

@aminya aminya added the bug Something isn't working label Dec 11, 2020
@aminya
Copy link
Member

aminya commented Dec 11, 2020

@UziTech What is this error?
image

@reblevins @phromo Sorry about this issue, and the late response. I did not get a notification. I wish you had tagged me.

@aminya aminya pinned this issue Dec 11, 2020
@UziTech
Copy link
Member

UziTech commented Dec 12, 2020

It looks like the language server threw the error "Unhandled method textDocument/documentSymbol" without more info I couldn't tell you more.

@aminya
Copy link
Member

aminya commented Dec 12, 2020

  • install this package and language-vue
  • open the .vue file in the spec folder.
  • open dev tools and see the error

@UziTech
Copy link
Member

UziTech commented Dec 12, 2020

Looks like this might be the issue vuejs/vetur#2387

@aminya
Copy link
Member

aminya commented Dec 12, 2020

Looks like this might be the issue vuejs/vetur#2387

Yeah. seems like the same thing. Maybe we should set a project for testing instead.

@aminya
Copy link
Member

aminya commented Dec 12, 2020

Normally, when I begin typing, it displays a list of possibilities, I pick the one I want, hit enter or tab and it completes it for me. That part is working fine, however for some reason it is deleting the character right in front of where the cursor started.

Maybe I misunderstood the issue. This seems to be the issue that was fixed in atom-languageclient

atom-community/atom-languageclient#99

@aminya
Copy link
Member

aminya commented Dec 12, 2020

I added a project under spec/project/hello-world. Open it in a new window and run pnpm i. You will get a lot more errors. This does not seem to be specific to only one vue file.

image

@aminya
Copy link
Member

aminya commented Dec 12, 2020

OK. I got the datatips, outline, etc working with vls 0.5. I downgraded vls to 0.5. We need to see why 0.6 does not work.

@yoyo930021
Copy link

This is my solution and suggestion.
vuejs/vetur#2561 (comment)

@aminya aminya closed this as completed in 634a461 Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

5 participants