Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ios section to settings.json, added basic tests #6

Closed

Conversation

arazantsau
Copy link

@arazantsau arazantsau commented Sep 9, 2019

  • Modified settings.json (added sections for iOS devices/driver configuration)
  • Added basic integration tests for iOS
  • Added some screens (page objects)

PR related to #5 - only part of tests

…guration)

- Added basic integration tests for iOS
- Added some screens (page objects)
a.ryazantsev added 2 commits September 9, 2019 16:37
- Updated .gitignore (removed .zip)
@arazantsau
Copy link
Author

@DmitryBogatko please review

import samples.ios.testapp.screens.MainScreen;
import samples.ios.testapp.screens.TwoItemsAlertScreen;

public class IOSBasicInteractionsTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need folder 'sample'?
why we test only 'Basic'? Our goal is up to 90% of the code should be covered with tests. Will the rest of tests developed later?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , will cover the other functionality in next prs

}

@Test
public void testSendKeysToInput() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, rename all the tests to patter like:
testShouldBePossibleToSendTextToElement()

do we really need MainScreen for such tests? Can we use elements factory directly here?

public void testSendKeysToInput() {
MainScreen mainScreen = new MainScreen();
Assert.assertTrue(mainScreen.isDisplayed(), "Main screen of app wasn't loaded");
mainScreen.enterTextToFirstField("Hello World!");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move "Hello World!" to local method variable

MainScreen mainScreen = new MainScreen();
mainScreen.tapShowAlert();
TwoItemsAlertScreen twoItemsAlertScreen = new TwoItemsAlertScreen();
Assert.assertTrue(twoItemsAlertScreen.isDisplayed(), "Alert wasn't opened");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we verify the same twice?

@paveliam paveliam linked an issue May 5, 2020 that may be closed by this pull request
@paveliam paveliam closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement iOS integration tests
4 participants