Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproducible builds: scala 3 tasty differences in pekko-http-core HttpEntity.tasty #476

Open
raboof opened this issue Feb 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@raboof
Copy link
Member

raboof commented Feb 9, 2024

aside scala/scala3#17330 , I'm seeing differences in the tasty segments of Scala 3 artifacts.

HttpEntity.tasty seems to refer to different source paths:

 source paths:
         0: http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpEntity.scala
      2063: http-core/target/scala-3.3.1/src_managed/HttpMessage.scala

vs

 source paths:
         0: http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpEntity.scala
      2063: http-core/src/main/scala/org/apache/pekko/http/impl/engine/parsing/ParserOutput.scala

It's not clear to me whether/how those source paths are used.

@raboof raboof added the bug Something isn't working label Feb 9, 2024
@raboof
Copy link
Member Author

raboof commented Feb 9, 2024

@raboof raboof self-assigned this Feb 10, 2024
@raboof
Copy link
Member Author

raboof commented Feb 10, 2024

Some findings:

  • I'm still seeing this behavior with Scala 3.4.1-RC1-bin-20240208-7bcfce2-NIGHTLY
  • It seems to sometimes think (some code related to) ResponseEntity is defined in ParserOutput for some reason?
  • I haven't caught it to see what it thinks is defined in HttpMessage.scala - but if that's about ResponseEntity as well, that'd also be wrong, as ResponseEntity is defined in HttpEntity.scala.

@raboof raboof removed their assignment Feb 10, 2024
@raboof
Copy link
Member Author

raboof commented Feb 13, 2024

The HttpMessage.scala reference is also somehow related to ResponseEntity. I've been prodding at this with a simplified build in a throwaway branch at https://github.com/raboof/incubator-pekko-http/tree/reproduce-tasty

@raboof
Copy link
Member Author

raboof commented Oct 1, 2024

Looks like this should be fixed in 3.3.5 with scala/scala3#21154

possibly causing what we've seen in the 1.1.0 release at https://arnout.engelen.eu/reproducible-builds-diffoscope-output-pekko-http-core_3-1.1.0.jar/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant