Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated functions from the codebase #1327

Open
kevinjqliu opened this issue Nov 15, 2024 · 4 comments
Open

Remove usage of deprecated functions from the codebase #1327

kevinjqliu opened this issue Nov 15, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@kevinjqliu
Copy link
Contributor

kevinjqliu commented Nov 15, 2024

Apache Iceberg version

None

Please describe the bug 🐞

Functions that are marked deprecated emit a warning. We should remove the use of deprecated functions from the codebase.

List of deprecated functions
https://github.com/search?q=repo%3Aapache%2Ficeberg-python+deprecated%28+language%3APython&type=code&l=Python

For example, #1318

@kevinjqliu kevinjqliu added the good first issue Good for newcomers label Nov 15, 2024
@ndrluis
Copy link
Collaborator

ndrluis commented Nov 16, 2024

@kevinjqliu Could you explain what you expect? I didn't understand the purpose of this issue. I believe we are supposed to warn the user when they use a deprecated API.

Were you referring to removing the deprecated code from version 0.8.0?

@kevinjqliu
Copy link
Contributor Author

@ndrluis yea the difference is to not use the deprecated API in pyiceberg's own codebase, which will emit warnings. For example, #1326 removed the use of identifier_to_tuple_without_catalog.

@ndrluis
Copy link
Collaborator

ndrluis commented Nov 16, 2024

Oh, ok. I believe we need to work on #1099. The way we are currently working makes it hard to deprecate because most of our code is public.

@kevinjqliu
Copy link
Contributor Author

That's true. For the short term, it'll be good to go through the API already marked for deprecation and make sure the codebase itself is not using them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants