Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency to FAB is removed in Connection Forms #42016

Open
2 tasks done
Tracked by #39593
jscheffl opened this issue Sep 5, 2024 · 0 comments
Open
2 tasks done
Tracked by #39593

Dependency to FAB is removed in Connection Forms #42016

jscheffl opened this issue Sep 5, 2024 · 0 comments
Labels
airflow3.0:candidate Potential candidates for Airflow 3.0 area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Milestone

Comments

@jscheffl
Copy link
Contributor

jscheffl commented Sep 5, 2024

Description

Relates to #39593

AFter a PoC in #41656 and the Airflow 3 Dev Call this is a follow-up issue to keep track of the efforts to remove the FAB dependency from ProvidersManager Connection Forms for Custom fields.

Technical Idea:

  • Make the custom form field definition into the provider.yaml description as structure
    • NO python code!
    • Follow the structure of JSON Schema like Custom Form fields in DAG Trigger UI (just as YAML/JSON dict)
    • On scheduler where providers are loaded persist the structure to DB
    • WebUI REST API can load the dict information from DB and render UI w/o need to have provider code available and initialized
      • Benefit: Less security risk of exposure due to bad code/dependencies, faster loading of web server API on start (=less imports needed)
  • Migrate existing providers

Use case/motivation

FAB should be an optional dependency and UI should eb able to render custom form fields w/o FAB installed.

Currently custom connection fields are defined in Python Code. This makes additional dependency that Python Provider code must be deployed and loaded in Webserver as well as FAB is needed to render the UI.

Related issues

Airflow 3: #39593
PoC PR: #41656

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@jscheffl jscheffl added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet airflow3.0:candidate Potential candidates for Airflow 3.0 labels Sep 5, 2024
@dosubot dosubot bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 5, 2024
@kaxil kaxil added this to the Airflow 3.0.0 milestone Sep 17, 2024
@jscheffl jscheffl removed the needs-triage label for new issues that we didn't triage yet label Sep 19, 2024
@jscheffl jscheffl mentioned this issue Oct 15, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:candidate Potential candidates for Airflow 3.0 area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

2 participants