Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the concept of user-facing "Active" DAG in UI & API #41519

Open
Tracked by #39593
kaxil opened this issue Aug 16, 2024 · 4 comments
Open
Tracked by #39593

Rename the concept of user-facing "Active" DAG in UI & API #41519

kaxil opened this issue Aug 16, 2024 · 4 comments
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Milestone

Comments

@kaxil
Copy link
Member

kaxil commented Aug 16, 2024

Same as #39593 but given we are now releasing Airflow 3.0 we can change this in a backwards-incompatible way.

Apart from just the UI, we need to change the filter in the API too. Example, we have only_active filter in "List DAGs" endpoint: https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dags

image

@kaxil kaxil mentioned this issue Aug 16, 2024
10 tasks
@dosubot dosubot bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Aug 16, 2024
@kaxil kaxil added this to the Airflow 3.0.0 milestone Aug 16, 2024
@kaxil kaxil added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 16, 2024
@kaxil
Copy link
Member Author

kaxil commented Aug 16, 2024

Some suggestions from the Dev call on 8th August:

  • @dstandish : Unpaused & Paused.
  • @bbovenzi : Enabled/paused
  • @ashb 's comment: I like pause/unpaused, stale (vs not stale, but not stale doesn’t really show up anywhere) for the states/values in API and DB. (Or paused/enabled is free to if “stale” is the state for dags-where-file-doesn’t-exist anymore)

cc @eladkal

@dstandish
Copy link
Contributor

I think it might be helpful to consider UI and API independently.

First question, what functionality do we want in the UI?

I think I always assumed that it just meant paused vs unpaused.

And, if you don't have orphaned dags, that is acutally true, I think.

Here's a proposal. Just add one more category: "missing" a.k.a. "orphaned" a.k.a. "inactive"

And then you just have 4 categories: all, enabled, disabled, missing

Enabled / disabled seems like better terminology than paused / unpaused. Paused vs unpaused makes less sense for unscheduled dags.

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 1, 2024

I am playing around with renaming it in the new UI. I still not sure exactly what to put:

Screenshot 2024-10-01 at 10 25 59 AM Screenshot 2024-10-01 at 10 26 05 AM

@raphaelauv
Copy link
Contributor

raphaelauv commented Nov 17, 2024

Also a new option (and button) to disable new dag_run but keep running one finishing

so stop the scheduler to create a new dag_run based on schedule ( like when dag is disable ) and not put in running queued dags
BUT
keep scheduling tasks of dags already in running state

so dag could be running_and_scheduling or running or stop state

wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

No branches or pull requests

4 participants