Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Databricks provider to depend on databricks-sql-connector >= 3.1.0 #39274

Closed
2 tasks done
sunchao opened this issue Apr 26, 2024 · 4 comments · Fixed by #43272
Closed
2 tasks done

Update Databricks provider to depend on databricks-sql-connector >= 3.1.0 #39274

sunchao opened this issue Apr 26, 2024 · 4 comments · Fixed by #43272
Assignees
@sunchao
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:databricks

Comments

@sunchao
Copy link
Member

sunchao commented Apr 26, 2024

Description

We are trying to upgrade to urllib3 2.x but faced a few challenges in terms of dependencies w.r.t Databricks, in particular we use dbt-databricks as well as apache-airflow-providers-databricks:

  • urllib3>=2 requires dbt-core1.8.x (e.g., dbt-core1.8.0b3)
  • dbt-core1.8.0b3 requires dbt-databricks1.8.x (e.g., dbt-databricks1.8.0b2)
  • dbt-databricks1.8.0b2 requires databricks-sql-connector<3.2.0,>=3.1.0
  • However, apache-airflow-providers-databricks (latest 6.3.0 release) requires databricks-sql-connector!=2.9.0,<3.0.0,>=2.0.0.

Ideally, it'd be great if apache-airflow-providers-databricks can upgrade its dependency of databricks-sql-connector to >=3.1.0.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@sunchao sunchao added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Apr 26, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Apr 26, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@potiuk
Copy link
Member

potiuk commented Apr 26, 2024

Feel free to attempt to upgrade it.

@eladkal eladkal added area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:databricks and removed kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Apr 26, 2024
@Taragolis
Copy link
Contributor

AFAIK databricks-sql-connector only supports SQLAlchemy 2, but Airflow and some components (FAB) only works with 1.4

@sunchao
Copy link
Member Author

sunchao commented Apr 28, 2024

Thanks @Taragolis ! Yes, looks like this depends on #28723

@rubanolha rubanolha mentioned this issue Oct 1, 2024
Closed
@eladkal eladkal mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunchao sunchao

Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:databricks
Projects
None yet
Milestone
No milestone
4 participants
@sunchao @potiuk @Taragolis @eladkal