Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OBJ tests and examples #633

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update OBJ tests and examples #633

merged 2 commits into from
Dec 12, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Dec 12, 2024 •
edited
Loading

📝 Description

  1. Upgrade Ansible Collection for AWS to v9.1.0.
  2. Add attributes ceph and region to resolve the issue of InvalidLocationConstraint.
  3. Remove unnecessary steps in the workflow.
  4. Replace s3_url, an alias of endpoint_url, with endpoint_url.
  5. Use HTTPS in the URLs.

✔️ How to Test

make TEST_ARGS="-vvv object_basic" test
make TEST_ARGS="-vvv object_keys_basic" test

GHA results:
https://github.com/linode/ansible_linode/actions/runs/12304640432
https://github.com/linode/ansible_linode/actions/runs/12304643510

@zliang-akamai zliang-akamai requested a review from a team as a code owner December 12, 2024 20:54
@zliang-akamai zliang-akamai requested review from jriddle-linode and ezilber-akamai and removed request for a team December 12, 2024 20:54
@ykim-akamai
Copy link
Contributor

Thank you for addressing this!

@ykim-akamai ykim-akamai self-requested a review December 12, 2024 20:58
ezilber-akamai
ezilber-akamai approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything passing locally. LGTM!

@zliang-akamai zliang-akamai merged commit 88e6107 into dev Dec 12, 2024
16 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/obj-tests-examples branch December 12, 2024 22:03
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

@jriddle-linode jriddle-linode Awaiting requested review from jriddle-linode jriddle-linode is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid LocationConstraint causing error on non-aws (ceph) object storage services
3 participants
@zliang-akamai @ykim-akamai @ezilber-akamai