Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jason optional, allow replacing with Poison #4

Open
angelikatyborska opened this issue Apr 13, 2020 · 1 comment
Open

Make Jason optional, allow replacing with Poison #4

angelikatyborska opened this issue Apr 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@angelikatyborska
Copy link
Owner

angelikatyborska commented Apr 13, 2020

For projects that already use Poison for JSONs, it might be annoying that this library requires Jason.

It should be possible to allow to choose either one or the other, like Phoenix currently does:
https://github.com/phoenixframework/phoenix/blob/51baf69993100c7ef40d097b02285ff28e4e16c9/lib/phoenix.ex#L69-L71
https://github.com/phoenixframework/phoenix/blob/2e5711c102a260a8d9457229c3dfd33f91c7cf99/lib/phoenix.ex#L87

However, that would make it slightly harder for everyone else to start using the library, because now everyone would have to explicitly add a JSON library as a dependency too (if it's not already there).

Are there any other popular JSON libraries that this one should support?

Please react with 👍 if you think that's a change worth adding.

@angelikatyborska angelikatyborska added the enhancement New feature or request label Apr 13, 2020
@jc00ke
Copy link

jc00ke commented Jun 18, 2024

This has maybe gotten a little nicer with Erlang 27 and the new :json module. IIRC Jason is going to use it by default if on Erlang >= 27, so maybe with a new version you can rev the requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants