Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save all types of values as str when JSON export #864

Open
2 tasks done
DenisDudnik opened this issue Dec 17, 2024 · 0 comments
Open
2 tasks done

Save all types of values as str when JSON export #864

DenisDudnik opened this issue Dec 17, 2024 · 0 comments

Comments

@DenisDudnik
Copy link

Checklist

  • The bug is reproducible against the latest release or master.
  • There are no similar issues or pull requests to fix it yet.

Describe the bug

When exporting data to JSON, the values are converted to strings, which interferes with proper handling of the data in the resulting file.

Steps to reproduce the bug

Export a table, check the values, they all will be strings (like "name": "1").

Expected behavior

Original types in JSON file (like "name": 1).

Actual behavior

"name": "1"

Debugging material

No response

Environment

  • Ubuntu 22.04 / Python 3.10 / sqladmin 0.20.1

Additional context

I'll provide a PR for the fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant