Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd_hsmp.h version mismatch with kernel #13

Open
trixirt opened this issue Aug 10, 2024 · 1 comment
Open

amd_hsmp.h version mismatch with kernel #13

trixirt opened this issue Aug 10, 2024 · 1 comment

Comments

@trixirt
Copy link

trixirt commented Aug 10, 2024

On Fedora rawhide kernel version 6.11.0-0.rc2.23.fc41.x86_64
This is a typical error

.../esmi_ib_library/src/e_smi.c: In function ‘esmi_rapl_units_hsmp_mailbox_get’:
.../esmi_ib_library/src/e_smi.c:566:27: error: ‘HSMP_GET_RAPL_UNITS’ undeclared (first use in this func
tion); did you mean ‘HSMP_GET_RAILS_SVI’?
566 | msg.msg_id = HSMP_GET_RAPL_UNITS;
| ^~~~~~~~~~~~~~~~~~~
| HSMP_GET_RAILS_SVI

amd_hsmp.h is from the kernel and has this as its hsmp_message_ids

    HSMP_GET_METRIC_TABLE,          /* 24h Get metrics table */                                                      
    HSMP_GET_METRIC_TABLE_DRAM_ADDR,/* 25h Get metrics table dram address */                                         
    HSMP_MSG_ID_MAX,                                                                                                 

};

HSMP_GET_RAPL_UNITS is not part of the kernel's messages, it appears to come from the oot driver here
https://github.com/amd/amd_hsmp/blob/master/amd_hsmp.h#L56

This may have been ok if this was just a developement issue, but this has been released in esmi_so_ver-4.0

This project can not assume that the user is using the oot driver now that it part of the kernel. It's use must adapt to whatever kernel is being used. There is no obvious version in the amd_hsmp.h, likely it needs one.

@sumachidanand
Copy link
Contributor

Hi,
Yes, we understand the problem, but as we all know, getting some changes accepted in linux kernel takes its own time. At the same time there will be some customers who want the new platform support in a short span of time, so we support them through amd_hsmp github repo. We are working on addressing this in a better way as well.
Thank you for using our library and bringing up this issue here. We will address this issue soon in a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants