Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videohash 'is_similar' function returns True for different videos #101

Open
steph-ieffam opened this issue Jan 29, 2023 · 0 comments
Open

Comments

@steph-ieffam
Copy link

steph-ieffam commented Jan 29, 2023

BUG REPORT
the videohash function is_similar returns True even when the videos are different.

NOTES:
One thing I noticed is that the is_similar function seems to be not correctly implemented. Basically this function sometimes returns True even though videos are completely different. I expect the is_similar function to return True for videos that at least shares some common characteristics as video length for example.

How are two videos supposed to be the equal if their length is not even similar? I would add a check prior than generating the hash value.

So, the videohash code should also take video length in consideration when comparing two videos for similarities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant