9 test failures

[Apteryks]

Describe the bug

Running the test suite of aiohttp 3.11.10, I see a few test failures as well as errors, for reasons unclear.

To Reproduce

Run the test suite with pytest in an environment having Python 3.10.7 and the following direct dependencies:

[email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected]

Expected behavior

All tests pass.

Logs/tracebacks

TOTAL                                        37521   8794    77%

============================= slowest 10 durations =============================
9.51s call     tests/test_run_app.py::TestShutdown::test_shutdown_new_conn_rejected
4.01s call     tests/test_run_app.py::TestShutdown::test_shutdown_pending_handler_responds
2.51s call     tests/test_run_app.py::TestShutdown::test_shutdown_wait_for_handler
2.41s call     tests/test_run_app.py::TestShutdown::test_shutdown_handler_cancellation_suppressed
2.01s call     tests/test_client_functional.py::test_read_timeout_between_chunks[pyloop]
2.00s call     tests/test_client_functional.py::test_set_cookies_max_age[pyloop]
1.61s call     tests/test_run_app.py::TestShutdown::test_shutdown_timeout_handler
1.51s call     tests/test_run_app.py::TestShutdown::test_shutdown_timeout_not_reached
1.06s call     tests/test_benchmarks_web_urldispatcher.py::test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]
1.01s call     tests/test_client_functional.py::test_readline_error_on_conn_close[pyloop]
=========================== short test summary info ============================
SKIPPED [1] tests/test_client_session.py:951: The check is applied in DEBUG mode only
SKIPPED [1] tests/test_client_request.py:1207: Needs Task.cancelling()
SKIPPED [1] tests/test_helpers.py:324: Python 3.11+ is required for .cancelling()
SKIPPED [1] tests/test_helpers.py:343: Python 3.11+ is required for .cancelling()
SKIPPED [1] tests/test_connector.py:3320: Proactor Event loop present only in Windows
SKIPPED [1] tests/test_connector.py:3103: Proactor Event loop present only in Windows
SKIPPED [1] tests/test_connector.py:3111: Proactor Event loop present only in Windows
SKIPPED [1] tests/test_connector.py:3122: Proactor Event loop present only in Windows
SKIPPED [1] tests/test_multipart_helpers.py:446: should raise decoding error: %82 is invalid for latin1
SKIPPED [1] tests/test_multipart_helpers.py:455: should raise decoding error: %E4 is invalid for utf-8
SKIPPED [1] tests/test_multipart_helpers.py:510: urllib.parse.unquote is tolerate to standalone % chars
SKIPPED [1] tests/test_multipart_helpers.py:519: urllib.parse.unquote is tolerate to standalone % chars
SKIPPED [1] tests/test_multipart_helpers.py:99: need more smart parser which respects quoted text
SKIPPED [1] tests/test_urldispatch.py:1021: aiohttp folder is not placed in user's HOME
SKIPPED [1] tests/test_web_app.py:365: The check is applied in DEBUG mode only
SKIPPED [1] tests/test_resolver.py:404: aiodns <3.2.0 required
SKIPPED [1] tests/test_web_functional.py:192: Needs Task.cancelling()
SKIPPED [1] tests/test_web_runner.py:133: Proactor Event loop present only in Windows
SKIPPED [1] tests/test_web_runner.py:121: Proactor Event loop present only in Windows
XFAIL tests/autobahn/test_autobahn.py::test_client
XFAIL tests/autobahn/test_autobahn.py::test_server
XFAIL tests/test_connector.py::test_del_with_scheduled_cleanup[pyloop]
XFAIL tests/test_client_functional.py::test_broken_connection[pyloop]
XFAIL tests/test_http_parser.py::test_parse_unusual_request_line[c-parser-pyloop] - Regression test for Py parser. May match C behaviour later.
XFAIL tests/test_http_parser.py::test_http_request_parser_utf8_request_line[c-parser-pyloop] - Regression test for Py parser. May match C behaviour later.
XFAIL tests/test_http_parser.py::test_parse_uri_utf8[c-parser-pyloop] - reason: Not valid HTTP. Maybe update py-parser to reject later.
FAILED tests/test_client_request.py::test_default_loop[pyloop] - DeprecationWarning: There is no current event loop
FAILED tests/test_imports.py::test___all__ - ValueError: Pytest terminal summary report not found
FAILED tests/test_imports.py::test_web___all__ - ValueError: Pytest terminal summary report not found
FAILED tests/test_circular_imports.py::test_no_warnings[aiohttp._http_parser] - subprocess.CalledProcessError: Command '('/gnu/store/jjzbav1s0x8lqg1aal13irspwwblwdf4-python-wrapper-3.10.7/bin/python', '-W', 'error', '-W', "ignore:module 'sre_constants' is deprecated:DeprecationWarning:pkg_resources._vendor.pyparsing", '-W', 'ignore:Creating a LegacyVersion has been deprecated and will be removed in the next major release:DeprecationWarning:', '-W', 'ignore:pkg_resources is deprecated as an API:DeprecationWarning', '-c', 'import aiohttp._http_parser')' returned non-zero exit status 1.
FAILED tests/test_circular_imports.py::test_no_warnings[aiohttp._http_writer] - subprocess.CalledProcessError: Command '('/gnu/store/jjzbav1s0x8lqg1aal13irspwwblwdf4-python-wrapper-3.10.7/bin/python', '-W', 'error', '-W', "ignore:module 'sre_constants' is deprecated:DeprecationWarning:pkg_resources._vendor.pyparsing", '-W', 'ignore:Creating a LegacyVersion has been deprecated and will be removed in the next major release:DeprecationWarning:', '-W', 'ignore:pkg_resources is deprecated as an API:DeprecationWarning', '-c', 'import aiohttp._http_writer')' returned non-zero exit status 1.
FAILED tests/test_test_utils.py::test_testcase_no_app - Failed: remains unmatched: '*RuntimeError*'
FAILED tests/test_circular_imports.py::test_no_warnings[aiohttp._websocket.mask] - subprocess.CalledProcessError: Command '('/gnu/store/jjzbav1s0x8lqg1aal13irspwwblwdf4-python-wrapper-3.10.7/bin/python', '-W', 'error', '-W', "ignore:module 'sre_constants' is deprecated:DeprecationWarning:pkg_resources._vendor.pyparsing", '-W', 'ignore:Creating a LegacyVersion has been deprecated and will be removed in the next major release:DeprecationWarning:', '-W', 'ignore:pkg_resources is deprecated as an API:DeprecationWarning', '-c', 'import aiohttp._websocket.mask')' returned non-zero exit status 1.
FAILED tests/test_web_app.py::test_set_loop_default_loop - DeprecationWarning: There is no current event loop
FAILED tests/test_streams.py::TestStreamReader::test_ctor_global_loop - DeprecationWarning: There is no current event loop
============ 9 failed, 3400 passed, 19 skipped, 7 xfailed in 41.68s ============

Python Version

$ python --version
3.10.7

aiohttp Version

$ python -m pip show aiohttp
3.11.10

multidict Version

$ python -m pip show multidict
5.2.0

propcache Version

$ python -m pip show propcache
0.2.1

yarl Version

$ python -m pip show yarl
1.18.3

OS

GNU+Linux

Related component

Client

Additional context

Found while updating the python-aiohttp package on GNU Guix.

Code of Conduct

• I agree to follow the aio-libs Code of Conduct

[Dreamsorcerer]

I think you'd have to do a bit more debugging to help figure it out.

The tests with 'There is no current event loop' are testing legacy stuff and I think those tests are gone in master (i.e. v4), so you may just want to ignore them and not waste your time on them.

The ones with 'subprocess.CalledProcessError' are trying to execute python in a subprocess, so seems something with your setup is causing that to fail. You could try editing it to log stdout/stderr and see what's happening (if it's not already logged in the rest of the pytest output).

[Dreamsorcerer]

Actually, all the failures other than the event loop ones are trying to run python in a subprocess. So, they are likely all the same problem with your setup.

[webknjaz]

I'd also suggest doing a git bisect if there's a known working version in that env.