Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest fixtures available for external projects #583

Closed
mkurek opened this issue May 16, 2018 · 5 comments
Closed

pytest fixtures available for external projects #583

mkurek opened this issue May 16, 2018 · 5 comments

Comments

@mkurek
Copy link

mkurek commented May 16, 2018

It would be great to have access to pytest fixtures defined in conftest.py or mock_server.py in external projects which depend on aiobotocore.

Similar setup is done for example in aiohttp's pytest_plugin

What do you think about it?

@thehesiod
Copy link
Collaborator

great idea, which ones in particular are you interested in?

@asvetlov
Copy link
Member

Side note.
It would be nice if public aiobotocore fixtures are prefixed with the project name, as we did it for pytest-aiohttp. Otherwise, a chance for naming conflict with other libs is high.

@mkurek
Copy link
Author

mkurek commented May 18, 2018

Hi. Right now we're using only s3-related fixtures: bucket_name, create_object and s3_server (but they have a lot of dependent fixtures underneath).

@jettify
Copy link
Member

jettify commented May 20, 2018

Mock server is simple wrapper around moto library, it starts real network server on specified port, as result we have better test coverage since we do not have to use mocking. Probably https://github.com/jotes/pytest-moto is better fit for you, but library was not updated for some time.

My point is that this fixture is not about aiobotocore and more about generic aws service substitution. We can easily create pytest plugin, but I suggest to give pytest-moto a try first.

@thehesiod
Copy link
Collaborator

thehesiod commented Jan 21, 2019

I'm going to close this in favor of #665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants