Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is max-width needed in the serial console? #9886

Open
FrozenGalaxy opened this issue Dec 12, 2024 · 5 comments
Open

Is max-width needed in the serial console? #9886

FrozenGalaxy opened this issue Dec 12, 2024 · 5 comments

Comments

@FrozenGalaxy
Copy link

Is it really necessary to limit the width? Having it expand to actual width seems way more logical

image

Line in question:

@tannewt
Copy link
Member

tannewt commented Dec 12, 2024

@andywarburton added it. They may have an opinion.

@ThomasAtBBTF
Copy link

ThomasAtBBTF commented Dec 12, 2024

I would instead / or additionaly like to see a "maxcol" and "maxline" setting/style.
Lately, I have been working on a project with an "Adafruit Qualia ESP32-S3 for TTL RGB-666 Displays" board.
And "struggle" with the serial output to the different LCD panels.
"Somewhere" is the information about the currently used font and also the information about the currently connected LCD panel.
Bringing this together would be helpful!

@andywarburton
Copy link

@andywarburton added it. They may have an opinion.

Aye it was a was a while ago but generally super long lines are considered bad for readability (see https://baymard.com/blog/line-length-readability for example).

I’m not especially tied to the decision though so feel free to revert if folks think something else is better.

@FrozenGalaxy
Copy link
Author

generally super long lines are considered bad for readability

Well, the messages are long anyway, except its scroll able right now.
It doesn't wrap lines/break the lines.

So removing the max width has no downside, other than having it be able to display longer lines if your screen width is wider..
Your point would only make sense if the console had wrap lines enabled, which it doesn't.

image

@RetiredWizard
Copy link

And "struggle" with the serial output to the different LCD panels. "Somewhere" is the information about the currently used font and also the information about the currently connected LCD panel. Bringing this together would be helpful!

I don't know if this addresses the issues you're having, but this code has helped me deal with different display dimenstions:

import board
from displayio import CIRCUITPYTHON_TERMINAL
from terminalio import FONT

height = round(board.DISPLAY.height/(FONT.bitmap.height*CIRCUITPYTHON_TERMINAL.scale))-1
width = round(board.DISPLAY.width/((FONT.bitmap.width/95)*CIRCUITPYTHON_TERMINAL.scale))-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants