-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is max-width needed in the serial console? #9886
Comments
@andywarburton added it. They may have an opinion. |
I would instead / or additionaly like to see a "maxcol" and "maxline" setting/style. |
Aye it was a was a while ago but generally super long lines are considered bad for readability (see https://baymard.com/blog/line-length-readability for example). I’m not especially tied to the decision though so feel free to revert if folks think something else is better. |
Well, the messages are long anyway, except its scroll able right now. So removing the max width has no downside, other than having it be able to display longer lines if your screen width is wider.. |
I don't know if this addresses the issues you're having, but this code has helped me deal with different display dimenstions: import board
from displayio import CIRCUITPYTHON_TERMINAL
from terminalio import FONT
height = round(board.DISPLAY.height/(FONT.bitmap.height*CIRCUITPYTHON_TERMINAL.scale))-1
width = round(board.DISPLAY.width/((FONT.bitmap.width/95)*CIRCUITPYTHON_TERMINAL.scale))-2 |
Is it really necessary to limit the width? Having it expand to actual width seems way more logical
Line in question:
circuitpython/supervisor/shared/web_workflow/static/style.css
Line 2 in 27456d5
The text was updated successfully, but these errors were encountered: