Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR's timer should start from when it was marked as ready instead of PR creation #1115

Open
rachaelparris opened this issue Dec 6, 2023 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@rachaelparris
Copy link

Description:
Draft PRs can be set as exempt in the action config. If that is set along with ignore-updates, then once a draft PR is marked as ready, its timer should start from the date it was marked as ready instead of its creation date.

Example config:

      - uses: actions/stale@v8
        with:
          ignore-pr-updates: true
          exempt-draft-pr: true
          days-before-stale: 10
          days-before-close: -1
          days-before-issue-stale: -1
          remove-stale-when-updated: false

Justification:
We are using this action to mark PRs that have been open for a while and need prioritized review. We skip draft PRs because they're not ready for review. A PR could be in draft for a few weeks and then marked as ready. It shouldn't be marked in need of prioritized review until it's been ready for the specified time.

Are you willing to submit a PR?
yes

@rachaelparris rachaelparris added feature request New feature or request to improve the current logic needs triage labels Dec 6, 2023
@marko-zivic-93
Copy link
Contributor

Hello @rachaelparris
Thank you for creating this issue. We will investigate it and come back to you as soon as we have some updates.

@alexremn
Copy link

Good day!

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants