-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of both steps and uses isn't flagged as an error #291
Comments
There's also a VScode extension for |
I was looking for a bug I'm encountering and I came across this issue, this actually isn't a bug, because you can call a reusable workflow from a job and omit This means that there are situations where steps can be omitted, but this checker probably needs to be smarter and only allow omission if |
It's a bug that the specific workflow isn't flagged as in error-- you're right that the initial summary wasn't strict enough about the conditions, although the body of the issue should have been sufficient for any engineer working on it. I've updated the summary. |
I proposed a fix, see actions/languageservices#98. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
csharp-qltest.yml
:Expected behavior
According to GitHub, this job isn't valid:
https://github.com/jsoref/codeql/actions/runs/7712430252
Generally if a workflow isn't valid, this extension will complain, e.g. if I add just
steps:
:Screenshots
Invalid workflow file: .github/workflows/csharp-qltest.yml#L1
No steps defined in
steps
and no workflow called inuses
for the following jobs: choose-runnerExtension Version
v0.26.2
Additional context
The text was updated successfully, but these errors were encountered: