Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"in" not included in phrases #206

Open
atus opened this issue May 2, 2014 · 2 comments
Open

"in" not included in phrases #206

atus opened this issue May 2, 2014 · 2 comments

Comments

@atus
Copy link
Contributor

atus commented May 2, 2014

Try here: http://jsfiddle.net/atus/b72Ut/show/
A quite common phrase: "in 2 weeks" can not be recognized.
"2 weeks" is parsed as the second week of the current year: "2 weeks : Mon Jan 06 2014 00:00:00 GMT+0100 (Mitteleuropäische Zeit)"
in is missing from the regexes, it should be added with the + stuff, I would edit it but this perhaps requires changing some core things to reflect in all languages.

@atus
Copy link
Contributor Author

atus commented May 2, 2014

I would add |in to the "/^(\\+|aft(er)?|from|hence)/": "^(\\+|aft(er)?|from|hence)" key

@abritinthebay
Copy link
Owner

Nice idea. I might be able to deal with this in the normalizer rather than the parser, but yes - it requires key adjustments.

I need to look at i18n in general to be honest. The current system works a lot better than the previous one but there are major issues with adjusting english keys atm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants