Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong CVSS3 V3.1 QR "MODERATE" #1186

Open
mnonnenmacher opened this issue Apr 24, 2023 · 1 comment
Open

Wrong CVSS3 V3.1 QR "MODERATE" #1186

mnonnenmacher opened this issue Apr 24, 2023 · 1 comment

Comments

@mnonnenmacher
Copy link

GitHub advisories provide the severity "MODERATE" and as a result VulnerableCode does also provide this severity which according to the specification should be "MEDIUM" instead.

For example, this severity is classified as "MODERATE" by GitHub:
GHSA-c7mc-q43h-5672

It is reported by VulnerableCode as:

{
  "reference_url": "https://github.com/advisories/GHSA-c7mc-q43h-5672",
  "reference_id": "GHSA-c7mc-q43h-5672",
  "scores": [
    {
      "value": "MODERATE",
      "scoring_system": "cvssv3.1_qr",
      "scoring_elements": ""
    }
  ],
  "url": "https://github.com/advisories/GHSA-c7mc-q43h-5672"
}

It would be good if VulnerableCode could map "MODERATE" to the correct "MEDIUM" in its API response.
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this issue Apr 24, 2023
@mnonnenmacher
fix(advisor): Map an incorrect vulnerability severity
1bff269 
For vulnerability references that come from GitHub advisories
VulnerableCode returns the severity as qualitative rating [1] as it is
provided by GitHub [2]. For "MEDIUM" severities GitHub uses the term
"MODERATE" which is is conflict with the specification. Therefore, map
"MODERATE" to "MEDIUM" in such cases.

[1]: https://www.first.org/cvss/v3.1/specification-document#Qualitative-Severity-Rating-Scale
[2]: aboutcode-org/vulnerablecode#1186

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this issue Apr 24, 2023
@mnonnenmacher
fix(advisor): Map an incorrect vulnerability severity
0caf8f7 
For vulnerability references that come from GitHub advisories
VulnerableCode returns the severity as qualitative rating [1] as it is
provided by GitHub [2]. For "MEDIUM" severities GitHub uses the term
"MODERATE" which is is conflict with the specification. Therefore, map
"MODERATE" to "MEDIUM" in such cases.

[1]: https://www.first.org/cvss/v3.1/specification-document#Qualitative-Severity-Rating-Scale
[2]: aboutcode-org/vulnerablecode#1186

Signed-off-by: Martin Nonnenmacher <[email protected]>
@sschuberth
Copy link

I've also reported this upstream to GitHub: github/advisory-database#2189

mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this issue Apr 24, 2023
@mnonnenmacher
fix(advisor): Map an incorrect vulnerability severity
16adfb0 
For vulnerability references that come from GitHub advisories
VulnerableCode returns the severity as qualitative rating [1] as it is
provided by GitHub [2]. For "MEDIUM" severities GitHub uses the term
"MODERATE" which is is conflict with the specification. Therefore, map
"MODERATE" to "MEDIUM" in such cases.

[1]: https://www.first.org/cvss/v3.1/specification-document#Qualitative-Severity-Rating-Scale
[2]: aboutcode-org/vulnerablecode#1186

Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @mnonnenmacher