Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High severity vulnerabilities - Newtonsoft, System.Security.Cryptography.Pkcs #363

Open
martinbryant opened this issue Feb 23, 2024 · 6 comments

Comments

@martinbryant
Copy link
Contributor

Package 'Newtonsoft.Json' 12.0.2 has a known high severity vulnerability, GHSA-5crp-9r3c-p9vr

Package 'System.Security.Cryptography.Pkcs' 6.0.1 has a known high severity vulnerability, GHSA-555c-2p6r-68mm

It looks like Giraffe needs updating to 6.x to be able to get Newtonsoft 13.x

@RicoSaupe
Copy link

will there be an update to this? Mend scanner is also recognizing this.

image

@kerams
Copy link
Collaborator

kerams commented May 23, 2024

I'm not sure how this is a Fable.Remoting concern. There is nothing preventing you from bumping Giraffe as far as I can see. And for that matter, Giraffe 5 doesn't restrict you to Newtonsoft.Json 12 either.

@RicoSaupe
Copy link

In my case its not about giraffe. its about fable remoting using the "older" Newtonsoft library and the request to bump this up to the latest version

@kerams
Copy link
Collaborator

kerams commented May 23, 2024

Sorry, but the argument still stands. You can use 13 if you want - Remoting does not hold you back.

image

@RicoSaupe
Copy link

Yes. I understand that i can use a higher version. Just wondering about the reason of the 12.x version. Is it for compatibility?

@Zaid-Ajaj
Copy link
Owner

Just wondering about the reason of the 12.x version. Is it for compatibility?

@RicoSaupe We can update it, I don't think there is a reason not to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants