Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "Enter" instead of clicking the "Update Profile" button fails to enable the TOTP #91

Closed
kasparsd opened this issue Nov 2, 2015 · 4 comments
Labels
TOTP Time-based One-time Passwords

Comments

@kasparsd
Copy link
Collaborator

kasparsd commented Nov 2, 2015

Looks like the personal_options_update filter isn't triggered when using the Enter key after entering the value in two-factor-totp-authcode input field.

@kasparsd kasparsd changed the title Using Enter key instead of "Update Profile" button fails to enable the TOTP Pressing "Enter" instead of clicking the "Update Profile" button fails to enable the TOTP Nov 10, 2015
@georgestephanis georgestephanis added the TOTP Time-based One-time Passwords label Dec 2, 2015
@georgestephanis
Copy link
Collaborator

Honestly, this needs a rewrite, probably moving more toward javascriptness. The fact that there isn't a button to update it in easy reach means some folks will probably update it and not think to scroll all the way to the bottom. Which kinda sucks.

We would probably gain significantly if @johnjamesjacoby's tabbed user profile page gets merged into core, so all the 2fa stuff could be bumped to a new tab.

@valendesigns
Copy link
Collaborator

@georgestephanis Could you link to the trac ticket?

@hummel124
Copy link

For me it's the other way round. I have to press enter to activate the TOTP.
When I use the "Update Profile" Button it is NOT activated!
Version is 0.1-dev-20170320

@kasparsd
Copy link
Collaborator Author

kasparsd commented Dec 3, 2024

Closing this as duplicate of #556 which will be fixed with #643.

@kasparsd kasparsd closed this as completed Dec 3, 2024
@jeffpaul jeffpaul removed this from the Future Release milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOTP Time-based One-time Passwords
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants