Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS consolidation #2415

Open
nijel opened this issue Dec 19, 2024 · 1 comment · May be fixed by #2424
Open

CSS consolidation #2415

nijel opened this issue Dec 19, 2024 · 1 comment · May be fixed by #2424
Assignees
@meel-hd
Labels
enhancement Adding or requesting a new feature.

Comments

@nijel
Copy link
Member

nijel commented Dec 19, 2024

Describe the problem

This repository has two nearly identical CSS files: weblate_web/static/style.css and weblate_web/static/style-rtl.css. One is used for LTR languages and the other for RTL. It is easy to miss doing changes in the other one.

Describe the solution you would like

There should be a way to have just a single CSS with overrides for RTL version inline. That would make the maintenance much easier.

Describe alternatives you have considered

No response

Screenshots

No response

Additional context

No response
@nijel nijel added the enhancement Adding or requesting a new feature. label Dec 19, 2024
@meel-hd
Copy link
Contributor

meel-hd commented Dec 20, 2024

Ok. I'm on it!

meel-hd added a commit to meel-hd/weblate-website that referenced this issue Dec 21, 2024
@meel-hd
Move RTL styles from style-rtl.css to style.css only
cf35cc9 
Changes:
 - All the RTL styles are moved into one file (style.css).
 - style-rtl.css is removed.
 - The base.html template is updated.

 close: WeblateOrg#2415
@meel-hd meel-hd linked a pull request Dec 21, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meel-hd meel-hd

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move RTL styles from style-rtl.css to style.css only meel-hd/weblate-website
2 participants
@nijel @meel-hd