Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mid-clickable expanded language lists #12434

Open
comradekingu opened this issue Sep 5, 2024 · 7 comments · May be fixed by #13309
Open

Mid-clickable expanded language lists #12434

comradekingu opened this issue Sep 5, 2024 · 7 comments · May be fixed by #13309
Assignees
@meel-hd
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience.

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Sep 5, 2024 •
edited
Loading

Papercut issue

Following up in #4656 which I suppose details what files are touched.

Describe the problem

  1. Open https://hosted.weblate.org/accounts/profile/#notifications
  2. Notice it has expanded languge lists.
  3. Be happy
  4. Notice elements are not mid-clickable

Describe the solution you would like

I want to visit projects on the followed part without following, to dip my toes in.
Do I want to follow, or do I not?

Describe alternatives you have considered

I thought about having a list of projects that are actively unfollowed.

Screenshots

bilde

Additional context

Some part of this functionality hopefully allows greater control in rooting out malicious/spam projects.
@nijel
Copy link
Member

nijel commented Sep 6, 2024

I'm not sure if allowing standard middle click is possible here. @meel-hd what do you think?

@meel-hd
Copy link
Contributor

meel-hd commented Sep 6, 2024

Yes, it is possible to allow middle-click functionality using event listeners in JavaScript. You can detect middle-clicks using the auxclick event and check if the button property is equal to 1 (which corresponds to the middle mouse button).

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Sep 21, 2024
@nijel
Copy link
Member

nijel commented Sep 23, 2024

Yes, I understand you can listen to the event. What @comradekingu probably wanted is to make these links so that middle-click would open up the language in a new tab.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience. and removed wontfix Nobody will work on this. labels Sep 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@meel-hd
Copy link
Contributor

meel-hd commented Dec 16, 2024

middle-click would open up the language in a new tab.

I think @comradekingu is in the Profile > Settings > Notifications tab (watched projects). He wants mid-click to open the project itself not a specific language. And as I said it is possible to add this functionality, of course.

I'll start on that now.

@meel-hd
Copy link
Contributor

meel-hd commented Dec 16, 2024

Update:

middle click has some weird behavior, I went with right click instead.

meel-hd added a commit to meel-hd/weblate that referenced this issue Dec 16, 2024
@meel-hd
Allow right click to inspect project
d1c57ba 
This allows right click in /accounts/profile/#notifications in the watched project list. So users can open a project and inspect it before follwing it or not, as was suggested in issue WeblateOrg#12434
@meel-hd meel-hd linked a pull request Dec 16, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meel-hd meel-hd

Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. ux Issues related to user experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow right click to inspect project meel-hd/weblate
3 participants
@nijel @comradekingu @meel-hd