-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arb string it is stored in the nested JSON format if using dots in keys #13037
Comments
Weblate shouldn't change the structure of existing files. Does this happen on editing? |
No matter if it's existing or not, the output arb files are always broken like in the example above. I guess the arb logic share code with the nested json code. That's why this behaviour happens. Maybe the same fix as for #4779 is required. This pr solves the bug only for normal json outputs |
When using ArbFiles, we stumbled across the same case in PR WeblateOrg/weblate#4779. See PR WeblateOrg/weblate#13037 To solve this, I tried to adapt PR translate#4161 to Arb files in the hope that it solves the actual problem
I try to fix it: translate/translate#5415 ^^. So maybe someone with more Phyton expirence can look into that :D |
translate/translate#5415 is a good starting point (it will fix newly creates strings), but still, Weblate should not change structure upon editing, that needs additional investigation. |
When using ArbFiles, we stumbled across the same case in PR WeblateOrg/weblate#4779. See PR WeblateOrg/weblate#13037 To solve this, I tried to adapt PR #4161 to Arb files in the hope that it solves the actual problem
When using ArbFiles, we stumbled across the same case in PR WeblateOrg/weblate#4779. See PR WeblateOrg/weblate#13037 To solve this, I tried to adapt PR #4161 to Arb files in the hope that it solves the actual problem
Describe the issue
We use arb files and have changed the translation framework in our frontend.
The extracted keys for the translations now have a dot. Which is allowed according to the arb specification.
The problem is that now the arb files are exported in nested JSON format as already described in this bug #4779 here.
This is not forbidden for ARB per se, but unfortunately other frameworks cannot necessarily deal with it. So now we also have problems and are looking for a workaround for it
I already tried
Steps to reproduce the behavior
Just use this arb file as import "Base file"
and as output translation you get this
Expected behavior
The expection is that you have this as a base file
and this as a output file
Screenshots
No response
Exception traceback
No response
How do you run Weblate?
Docker container
Weblate versions
5.8.3
Weblate deploy checks
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: