From f4ac69009b97ad806d6649721c50eec0d7aa7555 Mon Sep 17 00:00:00 2001
From: Mykola Stasiuk <93274808+st-myk@users.noreply.github.com>
Date: Mon, 16 Sep 2024 12:47:59 +0200
Subject: [PATCH] feat: make probes conditional (#466)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add conditional probes
* Add comments to probes
* Bump chart version
* Fix typos

Co-authored-by: Michal Čihař <michal@cihar.com>
---
 charts/weblate/Chart.yaml                | 2 +-
 charts/weblate/README.md                 | 2 +-
 charts/weblate/templates/deployment.yaml | 4 ++--
 charts/weblate/values.yaml               | 2 ++
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/charts/weblate/Chart.yaml b/charts/weblate/Chart.yaml
index 6b69fba..9e08a2d 100644
--- a/charts/weblate/Chart.yaml
+++ b/charts/weblate/Chart.yaml
@@ -4,7 +4,7 @@ appVersion: 5.7.2.1
 description: Weblate is a free web-based translation management system.
 name: weblate
 type: application
-version: 0.5.11
+version: 0.5.12
 home: https://weblate.org/
 icon: https://s.weblate.org/cdn/weblate.svg
 maintainers:
diff --git a/charts/weblate/README.md b/charts/weblate/README.md
index 1808995..1fdd3fb 100644
--- a/charts/weblate/README.md
+++ b/charts/weblate/README.md
@@ -1,6 +1,6 @@
 # weblate
 
-![Version: 0.5.11](https://img.shields.io/badge/Version-0.5.11-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.7.2.1](https://img.shields.io/badge/AppVersion-5.7.2.1-informational?style=flat-square)
+![Version: 0.5.12](https://img.shields.io/badge/Version-0.5.12-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.7.2.1](https://img.shields.io/badge/AppVersion-5.7.2.1-informational?style=flat-square)
 
 Weblate is a free web-based translation management system.
 
diff --git a/charts/weblate/templates/deployment.yaml b/charts/weblate/templates/deployment.yaml
index 80245d6..146cb21 100644
--- a/charts/weblate/templates/deployment.yaml
+++ b/charts/weblate/templates/deployment.yaml
@@ -179,7 +179,7 @@ spec:
                 name: {{ .Values.externalSecretName }}
             {{- end }}
           {{- end }}
-          {{- with .Values.livenessProbe }}
+          {{- if .Values.livenessProbe }}
           livenessProbe:
             httpGet:
               path: {{ $.Values.sitePrefix }}/healthz/
@@ -188,7 +188,7 @@ spec:
             initialDelaySeconds: {{ .initialDelaySeconds }}
             periodSeconds: {{ .periodSeconds }}
           {{- end }}
-          {{- with .Values.readinessProbe }}
+          {{- if .Values.readinessProbe }}
           readinessProbe:
             httpGet:
               path: {{ $.Values.sitePrefix }}/healthz/
diff --git a/charts/weblate/values.yaml b/charts/weblate/values.yaml
index e933f17..729a26e 100644
--- a/charts/weblate/values.yaml
+++ b/charts/weblate/values.yaml
@@ -175,11 +175,13 @@ tolerations: []
 
 affinity: {}
 
+# Can be removed when running Weblate service without probes configured
 livenessProbe:
   initialDelaySeconds: 300
   periodSeconds: 30
   failureThreshold: 10
 
+# Can be removed when running Weblate service without probes configured
 readinessProbe:
   initialDelaySeconds: 60
   periodSeconds: 30