Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasp library in wabt #1543

Open
1 of 14 tasks
binji opened this issue Sep 11, 2020 · 5 comments
Open
1 of 14 tasks

Use wasp library in wabt #1543

binji opened this issue Sep 11, 2020 · 5 comments
Assignees

Comments

@binji
Copy link
Member

binji commented Sep 11, 2020

For a while I've been working on a new library called wasp: https://github.com/binji/wasp. It has much of the same functionality as wabt, but written from the ground up to be a library rather than a suite of tools.

Wasp is now at the point where I'd like to look at incorporating it into wabt, so that features don't have to be implemented twice. Wasp could also end up being beneficial to binaryen, perhaps using just wasp's text parser.

Here is a high-level list of tasks that are required to start using wasp:

  • Move wasp library from binji/ to webassembly/
  • Add wasp library as a git submodule
  • Add a separate build configuration that builds wasp along with wabt
  • Replace wabt components with the wasp equivalent
    • binary reader
      • replace reader, keep the callback-based API
      • remove the callback API and use wasp visitor instead
    • binary writer
    • text reader
    • text writer
    • validator
    • text -> binary conversion
    • binary -> text conversion
  • Remove redundant wabt components (nearly everything, aside from tools, decompiler, interpreter, wasm2c stuff)

I'd like to do this as incrementally as possible, and on the main branch. Since a lot of these components depend on wabt's IR, that likely will be the last piece to remove. In the meantime, we can convert between wasp/wabt structures at the boundary.

@binji binji self-assigned this Sep 11, 2020
@binji binji pinned this issue Sep 11, 2020
@aardappel
Copy link
Contributor

Yup, a solid plan. Good idea to do it incrementally.

@dbezhetskov
Copy link
Contributor

Hi @binji, I see that there is no recent activity on this issues, do you still plan to use wasp in wabt?

@penzn
Copy link
Contributor

penzn commented Jul 22, 2021

A related question - do you need help? 😉

@binji
Copy link
Member Author

binji commented Aug 2, 2021

Sorry, I haven't been working on Wasm for almost a year now. I'm not certain whether this is a reasonable goal anymore, so I'll leave it to folks who have been working on wabt lately.

@keithw keithw unpinned this issue Apr 1, 2022
@HarikrishnanBalagopal
Copy link

HarikrishnanBalagopal commented Jan 30, 2024

@binji does wasp support WASI preview 2 component model? #2376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants