Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21.1 on 1.21.3 server - Shift-clicking the "Destroy Item" slot in the creative inventory deletes the items server-side but not client-side, causing a desync #940

Open
4 tasks done
Oublions opened this issue Dec 18, 2024 · 13 comments
Labels

Comments

@Oublions
Copy link

'/viaversion dump' Output

https://dump.viaversion.com/c9ec4ce7b79c18c65975c9865833a744fe45d395b433bc372714d599c65a1c5e

Server/Client Error

https://mclo.gs/Y46pDfb

I do not have any error but for reference, here we go!

Bug Description

Literally the MC-276292 bug, but only on backwards versions. On the native server versions, its working nicely.

Steps to Reproduce

  • Have a 1.21.3 PaperMC server with ViaVersion and ViaBackwards latest.
  • Connect in 1.21.1.
  • Get in creative.
  • Try to clear your inventory with shift-clicking the "Destroy Item" slot in the creative inventory.
  • and tada! the inventory is cleared in server-side. Client-side, you still have your inventory.

Expected Behavior

It should clears inventory.

Additional Server Info

I use latest versions of every plugins I have.

My build was from Spigot and tried out your snapshot ViaVer build, same bug. Also, an additionnal error shows.

[23:08:16 ERROR]: [ViaVersion] Error initializing plugin 'ViaVersion-5.2.1-SNAPSHOT.jar' in folder 'plugins' (Is it up to date?)
java.lang.NoSuchFieldError: Class com.viaversion.viaversion.api.type.types.version.Types1_21_4 does not have member field 'com.viaversion.viaversion.api.minecraft.entitydata.types.EntityDataTypes1_21 ENTITY_DATA_TYPES'
        at ViaBackwards-5.2.0.jar/com.viaversion.viabackwards.protocol.v1_21_4to1_21_2.rewriter.EntityPacketRewriter1_21_4.<init>(EntityPacketRewriter1_21_4.java:43) ~[ViaBackwards-5.2.0.jar:?]
        at ViaBackwards-5.2.0.jar/com.viaversion.viabackwards.protocol.v1_21_4to1_21_2.Protocol1_21_4To1_21_2.<init>(Protocol1_21_4To1_21_2.java:58) ~[ViaBackwards-5.2.0.jar:?]
        at ViaBackwards-5.2.0.jar/com.viaversion.viabackwards.api.ViaBackwardsPlatform.init(ViaBackwardsPlatform.java:148) ~[ViaBackwards-5.2.0.jar:?]
        at ViaBackwards-5.2.0.jar/com.viaversion.viabackwards.BukkitPlugin.lambda$new$0(BukkitPlugin.java:38) ~[ViaBackwards-5.2.0.jar:?]
        at ViaVersion-5.2.1-SNAPSHOT.jar/com.viaversion.viaversion.ViaManagerImpl.init(ViaManagerImpl.java:115) ~[ViaVersion-5.2.1-SNAPSHOT.jar:?]
        at ViaVersion-5.2.1-SNAPSHOT.jar/com.viaversion.viaversion.ViaVersionPlugin.onLoad(ViaVersionPlugin.java:88) ~[ViaVersion-5.2.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:18) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:40) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:561) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:289) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1235) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:340) ~[paper-1.21.3.jar:1.21.3-81-da71382]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Clip : https://imgur.com/a/rrqbXQU

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Dec 18, 2024

Platform: 1.21.3--81--da71382%20%28MC%3A%201.21.3%29
ViaVersion (5.2.0): 15 commits behind master
ViaBackwards(5.2.0): 8 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

@Barvalg Barvalg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
@FlorianMichael
Copy link
Member

Don't insult our bot, he is correct. Please update to dev builds from https://ci.viaversion.com/

@Oublions
Copy link
Author

Please read. I tried. Same error, same shit.

@FlorianMichael
Copy link
Member

Send a new dump url then

@Barvalg
Copy link
Member

Barvalg commented Dec 18, 2024

Platform: 1.21.3--81--da71382%20%28MC%3A%201.21.3%29
ViaVersion (5.2.1-SNAPSHOT): Even with master
ViaBackwards(5.2.0): 8 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

@Oublions
Copy link
Author

Its updated 💀

@FlorianMichael
Copy link
Member

You need to update ViaBackwards as well

@Oublions
Copy link
Author

there is no build at https://ci.viaversion.com/

@FlorianMichael
Copy link
Member

@Oublions
Copy link
Author

Still the same bug. https://dump.viaversion.com/84c30283a5ccd23ef313abb03eedf01812e2cb2d0564d7f4a62fa3e696235b54

And they should add ViaBackwards and ViaRewind on the homepage by the way of the jenkins website lol. It could save some time.

@Barvalg
Copy link
Member

Barvalg commented Dec 18, 2024

Platform: 1.21.3--81--da71382%20%28MC%3A%201.21.3%29
ViaVersion (5.2.1-SNAPSHOT): Even with master
ViaBackwards(5.2.1-SNAPSHOT): Even with master

@Barvalg Barvalg reopened this Dec 18, 2024
@Barvalg Barvalg removed the invalid label Dec 18, 2024
@FlorianMichael
Copy link
Member

FlorianMichael commented Dec 19, 2024

There are, you just have to read.
image

I can't reproduce the exception issue when using the latest ci from both ViaVersion and ViaBackwards, so you either just uploaded a new dump without doing testing again or something else in your setup is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants