Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's raining soldini, hallelujah #135

Closed
wants to merge 3 commits into from
Closed

It's raining soldini, hallelujah #135

wants to merge 3 commits into from

Conversation

TendTo
Copy link
Member

@TendTo TendTo commented Nov 1, 2020

Added the "soldini" easter egg (based on the idea of @alepiaz) [ closes #125 ]

It has been tested only bypassing the scheduling (making it run as soon as the bot is launched), so i hope someone can check if the scheduling will work properly.

Furthermore, a new field has been added in the settings.yaml, and it should be populated by a list of chats that will be targeted by the "soldini" easter egg

Also, maybe the MessageHandler "add_soldini" should run in a different group instead of the default 0. I'd like to hear your opinion on this

@TendTo TendTo requested a review from alepiaz November 1, 2020 15:59
@@ -34,3 +34,5 @@ test:

dev_group_chatid: 0
representatives_group: 0

easter_eggs_chat: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volendo potremmo considerare qualsiasi chatid < 0, quindi gruppi/supergruppi, non per forza un chat id specifico
se no ogni volta che creiamo un nuovo gruppo dovremmo "ottenere" il chat id e poi inserirlo qui, insomma ce la potremmo risparmiare questa cosa

Copy link
Member Author

@TendTo TendTo Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si, si può controllare se si tratta di gruppo/supergruppo caso per caso, ma non ho capito da dove dovremmo procurarci la lista di chat_id se non è hardcoded

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cioè, se non specifichi la lista di chat nei settings, da dove dovrebbe procurarsela il bot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non mi vengono soluzioni ottimali al problema

module/easter_egg_func.py Outdated Show resolved Hide resolved
module/easter_egg_func.py Show resolved Hide resolved
module/easter_egg_func.py Show resolved Hide resolved
@Helias
Copy link
Member

Helias commented Nov 12, 2020

Any clue? any ideas?

@TendTo
Copy link
Member Author

TendTo commented Nov 23, 2020

C'è crisi, soldini are not raining

@TendTo TendTo closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easter egg
2 participants