Problem running multiple CliWrap commands

[RabbitWolf62]

Hi,

I have a project that is using CliWrap to execute SC commands. The commands are used to install and start or stop and uninstall a BackgroundService as a Windows Service.

My code looks like this:

private static async void InstallService() {

    String executablePath;

    BufferedCommandResult result;

    if (!await IsServiceInstalled())
    {
        executablePath = Path.Combine(AppContext.BaseDirectory, "SpreadsheetInterfaceServer.exe");

        result = await Cli.Wrap("sc")
                          .WithArguments(args => args
                              .Add("create")
                              .Add(InstallServiceName)
                              .Add($"binPath={executablePath}")
                              .Add("start=auto"))
                          .WithValidation(CommandResultValidation.None)
                          .ExecuteBufferedAsync();

        if (result.ExitCode != 0)
        {
            // Display message indicating that the server could not be installed as a Windows service

            // Exit the program
            Environment.Exit(1);
        }

        result = await Cli.Wrap("sc")
                          .WithArguments(args => args
                              .Add("start")
                              .Add(InstallServiceName))
                          .WithValidation(CommandResultValidation.None)
                          .ExecuteBufferedAsync();

        // Display message indicating that the server was successfully installed as a Windows service
    }
    else
    {
        // Display message indicating that the server was already installed
    }
}

private static async void UninstallService() {

    BufferedCommandResult result;

    if (await IsServiceInstalled())
    {
        if (!await IsServiceStopped())
        {
            result = await Cli.Wrap("sc")
                              .WithArguments(args => args
                                  .Add("stop")
                                  .Add(InstallServiceName))
                              .WithValidation(CommandResultValidation.None)
                              .ExecuteBufferedAsync();
        }

        result = await Cli.Wrap("sc")
                          .WithArguments(args => args
                              .Add("delete")
                              .Add(InstallServiceName))
                          .WithValidation(CommandResultValidation.None)
                          .ExecuteBufferedAsync();

        if (result.ExitCode != 0)
        {
            // Display message indicating that the server could not be uninstalled as a Windows service

            // Exit the program
            Environment.Exit(1);
        }

        // Display message indicating that the server was successfully uninstalled as a Windows service
    }
    else
    {
        // Display message indicating that the server was not already installed
    }
}

private static async Task<Boolean> IsServiceInstalled() {

    BufferedCommandResult result = await Cli.Wrap("sc")
                                            .WithArguments(args => args
                                                .Add("query")
                                                .Add(InstallServiceName))
                                            .WithValidation(CommandResultValidation.None)
                                            .ExecuteBufferedAsync();

    return result.ExitCode == 0;
}

private static async Task<Boolean> IsServiceStopped() {

    BufferedCommandResult result = await Cli.Wrap("sc")
                                            .WithArguments(args => args
                                                .Add("query")
                                                .Add(InstallServiceName))
                                            .WithValidation(CommandResultValidation.None)
                                            .ExecuteBufferedAsync();

    return result.StandardOutput.Contains("STOPPED") || result.StandardOutput.Contains("STOPPING");
}

The problem I am having is that the first CliWrap("sc") works, but the program just stops and exits when executing the second CliWrap("sc").

However, I have found that I can get these calls to work if I put a debugger break in the CliWrap method in BufferedCommandExtensions:

public static CommandTask<BufferedCommandResult> ExecuteBufferedAsync(

    this Command command,
    Encoding standardOutputEncoding,
    Encoding standardErrorEncoding,
    CancellationToken forcefulCancellationToken,
    CancellationToken gracefulCancellationToken) {

    var stdOutBuffer = new StringBuilder();
    var stdErrBuffer = new StringBuilder();

    var stdOutPipe = PipeTarget.Merge(
        command.StandardOutputPipe,
        PipeTarget.ToStringBuilder(stdOutBuffer, standardOutputEncoding)
    );

    var stdErrPipe = PipeTarget.Merge(
        command.StandardErrorPipe,
        PipeTarget.ToStringBuilder(stdErrBuffer, standardErrorEncoding)
    );

    var commandWithPipes = command
        .WithStandardOutputPipe(stdOutPipe)
        .WithStandardErrorPipe(stdErrPipe);

    return commandWithPipes
        .ExecuteAsync(forcefulCancellationToken, gracefulCancellationToken)
        .Bind(async task =>
        {
            try
            {
                var result = await task;     <- Put breakpoint here

                return new BufferedCommandResult(
                    result.ExitCode,
                    result.StartTime,
                    result.ExitTime,
                    stdOutBuffer.ToString(),
                    stdErrBuffer.ToString()
                );
            }
            catch (CommandExecutionException ex)
            {
                throw new CommandExecutionException(
                    ex.Command,
                    ex.ExitCode,
                    $"""
                    Command execution failed, see the inner exception for details.

                    Standard error:
                    {stdErrBuffer.ToString().Trim()}
                    """,
                    ex
                );
            }
        });
}

If I put a breakpoint at the line indicated above and then continue from there, everything works fine.

Thank You,
Tracy

[Tyrrrz]

It's like throwing an exception that your application isn't handling. Does it step after await task? Try putting a try/catch around your code and add a debug breakpoint in the catch clause.

[RabbitWolf62]

Hi Tyrrrz,

I tried that, but no exception is thrown.

Tracy

[Tyrrrz]

Can you provide a minimal but complete reproduction for this?

[RabbitWolf62]

Hi, I have attached a simple example that reproduces the problem. Thank You, Tracy

…

On 5/25/2023 3:41 AM, Oleksii Holub wrote: Can you provide a minimal but complete reproduction for this? — Reply to this email directly, view it on GitHub <#211 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKD756W6SPG4KHX3DCM2IVDXH4ZO7ANCNFSM6AAAAAAYOTYCXE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[RabbitWolf62]

Hi, One thing to keep in mind is that you need to run Visual Studio as Administrator to use the SC command. Tracy

…

On 5/25/2023 3:41 AM, Oleksii Holub wrote: Can you provide a minimal but complete reproduction for this? — Reply to this email directly, view it on GitHub <#211 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKD756W6SPG4KHX3DCM2IVDXH4ZO7ANCNFSM6AAAAAAYOTYCXE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Tyrrrz]

I can't reproduce this because I don't have access to a Windows PC right now. Check if this issue also happens with other commands.

Also see if this is related: #210