Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin app modernization #21692

Open
1 task done
NullVoxPopuli opened this issue Nov 21, 2024 · 3 comments
Open
1 task done

Admin app modernization #21692

NullVoxPopuli opened this issue Nov 21, 2024 · 3 comments
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@NullVoxPopuli
Copy link

NullVoxPopuli commented Nov 21, 2024

Issue Summary

Hello! I noticed the admin app is 3.24, which is quite old.

Ember has a lot of very nice features in v6, and the upcoming edition, Polaris.

Since 3.24 -- these are all the features ya'll could have 🎉 :

  • gjs/gts - Docs - Interactive Tutorial - REPL
  • vite via The V2 App Blueprint, RFC
    • Fast initial build, and instant rebuilds.
  • better data patterns
  • better reactivity and component patterns and features
  • native typescript support (including blueprints)
  • typed templates
  • helpers can be plain functions
  • new APIs (ones that I found most fun, anyway)
  • any value can be used in any syntax position (components, modifiers, helpers, etc don't need to be in specific places) - https://guides.emberjs.com/release/in-depth-topics/rendering-values/
  • improved error messages (and template stacks reported in errors)
  • named blocks / slots
  • variable locations are now explicitly known, and you never need to wonder where something is defined (this now goes for components, helpers, modifiers, etc, too (when going all in on gjs/gts))
  • no more inject as service, you can import { service } from '@ember/service' directly
  • as of 6.1, all the addons in the blueprint are v2 addons (v2 addons are "normal npm libraries") which means your app doesn't build them (as your app does with classic / v1 addons)
  • no need for RSVP

Is there appetite for updating / receiving PRs that do updates?

Overall - these efforts fit in to the following categories

  • be less weird, improve understandability, eliminate magic
  • improve compatibility with the broader ecosystem and general / default expectations
  • improve performance (of the framework and the tooling)

Of note, I noticed that the monorepo here is using yarn@v1 -- this would need to change as yarn@v1 does a lot of incorrect things with dependencies, and tools like, vite will not allow for it (unless duplicate / incorrect dependencies are desirable haha)

Detailed releases blog entries:

Steps to Reproduce

I was poking around here: https://github.com/TryGhost/Ghost/blob/main/ghost/admin/package.json#L120

In particular ember-source 3.24 -> 3.28 should be super easy, as it's all non-breaking changes and you get a lot of really good features at 3.28, including gjs/gts.

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 21, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@NullVoxPopuli
Copy link
Author

NullVoxPopuli commented Nov 21, 2024

Why, @linear? it's rude to close without explanation 😢

@9larsons
Copy link
Contributor

Sorry! I definitely did not mean to close the Github issue.

@9larsons 9larsons reopened this Nov 22, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@9larsons 9larsons reopened this Nov 22, 2024
@crutchcorn
Copy link

Yarn has been upgraded to v4 here: #21818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Development

No branches or pull requests

3 participants