Library override the DPR setting in autonomy without chances to clamp / control it

[dghez]

I noticed that Tres set the DPR (see code) completely in autonomy without any way to control that, imho is conceptually wrong for couple of reasons:

1. The dev should be in charge to decide the DPR or at least be able to clamp. For example if the app is opened on a 3DPR mobile is gonna run at 3, that is completely insane.
2. The app should not change the dpr on resize without consent. I noticed it because i was setting manually in a range

  const dpr = MathUtils.clamp(window.devicePixelRatio, 1, 1.4) 
 renderer.value.setPixelRatio(dpr)

but on resize switching between monitors on my macbook was set back to 2 due the useDevicePixelRatio hook. This second point tho depends on the first one. If We decide to let the app handle the resize, it's 100% needed to add a clamp on that.

This can lead to some big issues, both perf wise and effect wise. I notice the "issue" because i was doing some effect in screen-space, where my resolution wasn't matching my DPR vec2 st = gl_FragCoord.xy / (gResolution * gDpr);

My take on this is that the library can take care of the DPR but at least give the user some way to control, like they don in r3f where you can set dpr=[low, high] that clamps it :)

Reproduction

---

Steps to reproduce

---

System Info

----

Used Package Manager

npm

Code of Conduct

• I agree to follow this project's Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[dghez]

hey @alvarosabu /. @andretchen0 saw you took care of this (love) but i think there is still an issue.
Everything works fine because dpr is correctly clamped, although if you try to switch between two monitors with different DPR it changes the DPR of the canvas even without triggering a resize (just move the window between the monitors).

You would think is fine buuut if you are working with screen resolution (so DPR) in a shader this behaviour is kinda odd because you need to update the screen-size there but there is no way to detect is changed without a resize currently.

IMHO solutions are 3

1. Don't update the DPR without a resize (so you can listen on a resize and update the dpr internally)
2. Use a ref for the DPR so it can be watched
3. Just set at the beginning and that's all

[andretchen0]

@dghez

Sure thing. Reopening.

We're currently discussing some changes to the core. I'll make sure that this is part of those discussions.