Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization of alerts #129

Open
3 tasks done
tomassanjuann opened this issue Sep 9, 2024 · 3 comments
Open
3 tasks done

Add customization of alerts #129

tomassanjuann opened this issue Sep 9, 2024 · 3 comments

Comments

@tomassanjuann
Copy link
Contributor

tomassanjuann commented Sep 9, 2024

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

It would be really interesting if there is a setting on the Teslemetry console to select which alert types stream. I would like to be able to configure scopes for the alerts and have it on the recent alerts / errors fields on Home Assistant. This can be useful to stream errors that appear only in service mode and not in the normal mode (UI Hidden).

This can be possible, setting "alert_types" on the fleet_telemery_config to "customer" and/or "service" scopes. I don't know if the Recent Alerts Endpoint can be used also.

Later on, this can be further enhanced providing the user the description of the alert using the "user_text" it returns

Additional context

Fleet API Config
Recent Alerts Endpoint

@Bre77
Copy link
Contributor

Bre77 commented Sep 9, 2024

So when streaming telemetry was first added to Teslemetry I did provide the ability to pick which alert types should be sent, but it became clear this provided so little value as we never saw an alert that was service or service_fix only. So I removed the UI and made everything default to customer alerts.

I'm not opposed to adding service and service_fix back, and would prefer to just make it the default to avoid having a semi confusing UI that does nothing.

Ill have to investigate the text you mentioned more though as I don't believe that's always present.

Edit: for what it's worth I've never seen a good use case for the alert data. If you find one let me know.

@tomassanjuann
Copy link
Contributor Author

Hi Brett, thanks for looking on to this.
My personal use is just to have a “log” outside the car. Every time I want to look into this, I need to go inside Service Mode, which if I can have it directly streamed (into Home Assistant or others) It will be better for me. Also, some alerts which appear under factory, service-fix or service, doesn't appear in normal UI mode. It's just an interesting function I'll be happy to have if possible.
Thanks!

@Bre77
Copy link
Contributor

Bre77 commented Sep 19, 2024

If you modify your streaming config on the Teslemetry console it will now enable service alerts by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants