Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nesting buttons or anchors in links #3250

Open
lorenzo-cavazzi opened this issue Jul 23, 2024 · 0 comments
Open

Avoid nesting buttons or anchors in links #3250

lorenzo-cavazzi opened this issue Jul 23, 2024 · 0 comments
Assignees

Comments

@lorenzo-cavazzi
Copy link
Member

With the new design, we introduced a new pattern for ListGroupItems with the whole row either linking to a page or opening a canvas, and a quick-actions button. This breaks some HTML rules by nesting buttons/anchors inside another anchor (see screenshot where the blue and yellow are an anchor and a button, and they are nested inside the parent anchor in blue).

image

We should make a new component that simplifies avoiding this behavior. Mind that we might want to compromise on the position by letting this component always be either the rightmost element or on the bottom for smaller screens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant