diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 8b3e35b53f..275f0e9599 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -3,7 +3,6 @@ name: build-pipeline on: pull_request: branches: - - develop - main - release/v* diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index de2de959da..d7ecd688c0 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -3,7 +3,7 @@ name: "Update PR labels and Block PR until related docs are shipped for the feat on: pull_request: branches: - - develop + - main types: [opened, edited, labeled, unlabeled] permissions: diff --git a/.github/workflows/e2e-k3s.yaml b/.github/workflows/e2e-k3s.yaml index ef5911f9b0..b09666fb80 100644 --- a/.github/workflows/e2e-k3s.yaml +++ b/.github/workflows/e2e-k3s.yaml @@ -42,7 +42,7 @@ jobs: kubectl create ns sample-application # apply hotrod k8s manifest file - kubectl -n sample-application apply -f https://raw.githubusercontent.com/SigNoz/signoz/develop/sample-apps/hotrod/hotrod.yaml + kubectl -n sample-application apply -f https://raw.githubusercontent.com/SigNoz/signoz/main/sample-apps/hotrod/hotrod.yaml # wait for all deployments in sample-application namespace to be READY kubectl -n sample-application get deploy --output name | xargs -r -n1 -t kubectl -n sample-application rollout status --timeout=300s diff --git a/.github/workflows/jest-coverage-changes.yml b/.github/workflows/jest-coverage-changes.yml index 56d4cf1b70..d5df9ce686 100644 --- a/.github/workflows/jest-coverage-changes.yml +++ b/.github/workflows/jest-coverage-changes.yml @@ -2,7 +2,8 @@ name: Jest Coverage - changed files on: pull_request: - branches: develop + branches: + - main jobs: build: @@ -11,7 +12,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 with: - ref: "refs/heads/develop" + ref: "refs/heads/main" token: ${{ secrets.GITHUB_TOKEN }} # Provide the GitHub token for authentication - name: Fetch branch diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index a440d2a5c7..e7123b8710 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -4,7 +4,6 @@ on: push: branches: - main - - develop tags: - v* diff --git a/.github/workflows/sonar.yml b/.github/workflows/sonar.yml index 8c62c12d1b..eff8de7c6b 100644 --- a/.github/workflows/sonar.yml +++ b/.github/workflows/sonar.yml @@ -3,7 +3,6 @@ on: pull_request: branches: - main - - develop paths: - 'frontend/**' defaults: diff --git a/.github/workflows/staging-deployment.yaml b/.github/workflows/staging-deployment.yaml index bbdbe32531..6125283a87 100644 --- a/.github/workflows/staging-deployment.yaml +++ b/.github/workflows/staging-deployment.yaml @@ -1,12 +1,12 @@ name: staging-deployment -# Trigger deployment only on push to develop branch +# Trigger deployment only on push to main branch on: push: branches: - - develop + - main jobs: deploy: - name: Deploy latest develop branch to staging + name: Deploy latest main branch to staging runs-on: ubuntu-latest environment: staging permissions: diff --git a/.github/workflows/testing-deployment.yaml b/.github/workflows/testing-deployment.yaml index 68a9b140cb..6362331e7b 100644 --- a/.github/workflows/testing-deployment.yaml +++ b/.github/workflows/testing-deployment.yaml @@ -44,7 +44,7 @@ jobs: git add . git stash push -m "stashed on $(date --iso-8601=seconds)" git fetch origin - git checkout develop + git checkout main git pull # This is added to include the scenerio when new commit in PR is force-pushed git branch -D ${GITHUB_BRANCH} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 613b225353..bed34bfd86 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -339,7 +339,7 @@ to make SigNoz UI available at [localhost:3301](http://localhost:3301) **5.1.1 To install the HotROD sample app:** ```bash -curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-install.sh \ +curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-install.sh \ | HELM_RELEASE=my-release SIGNOZ_NAMESPACE=platform bash ``` @@ -362,7 +362,7 @@ kubectl -n sample-application run strzal --image=djbingham/curl \ **5.1.4 To delete the HotROD sample app:** ```bash -curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-delete.sh \ +curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-delete.sh \ | HOTROD_NAMESPACE=sample-application bash ``` diff --git a/deploy/README.md b/deploy/README.md index 5e6740e6a7..55c3b6e8d4 100644 --- a/deploy/README.md +++ b/deploy/README.md @@ -58,7 +58,7 @@ from the HotROD application, you should see the data generated from hotrod in Si ```sh kubectl create ns sample-application -kubectl -n sample-application apply -f https://raw.githubusercontent.com/SigNoz/signoz/develop/sample-apps/hotrod/hotrod.yaml +kubectl -n sample-application apply -f https://raw.githubusercontent.com/SigNoz/signoz/main/sample-apps/hotrod/hotrod.yaml ``` To generate load: diff --git a/frontend/.husky/commit-msg b/frontend/.husky/commit-msg index cb50d87a2d..0afb1a6cb8 100755 --- a/frontend/.husky/commit-msg +++ b/frontend/.husky/commit-msg @@ -13,8 +13,3 @@ if [ "$branch" = "main" ]; then echo "${color_red}${bold}You can't commit directly to the main branch${reset}" exit 1 fi - -if [ "$branch" = "develop" ]; then - echo "${color_red}${bold}You can't commit directly to the develop branch${reset}" - exit 1 -fi \ No newline at end of file diff --git a/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go b/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go index bf07316bb2..67b32938f0 100644 --- a/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go +++ b/pkg/query-service/app/integrations/messagingQueues/kafka/sql.go @@ -9,25 +9,25 @@ func generateConsumerSQL(start, end int64, topic, partition, consumerGroup, queu query := fmt.Sprintf(` WITH consumer_query AS ( SELECT - serviceName, + resource_string_service$$name, quantile(0.99)(durationNano) / 1000000 AS p99, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count, - avg(CASE WHEN has(numberTagMap, 'messaging.message.body.size') THEN numberTagMap['messaging.message.body.size'] ELSE NULL END) AS avg_msg_size - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count, + avg(CASE WHEN has(attributes_number, 'messaging.message.body.size') THEN attributes_number['messaging.message.body.size'] ELSE NULL END) AS avg_msg_size + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 5 - AND msgSystem = '%s' - AND stringTagMap['messaging.destination.name'] = '%s' - AND stringTagMap['messaging.destination.partition.id'] = '%s' - AND stringTagMap['messaging.kafka.consumer.group'] = '%s' - GROUP BY serviceName + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.destination.name'] = '%s' + AND attributes_string['messaging.destination.partition.id'] = '%s' + AND attributes_string['messaging.kafka.consumer.group'] = '%s' + GROUP BY resource_string_service$$name ) SELECT - serviceName AS service_name, + resource_string_service$$name AS service_name, p99, COALESCE((error_count * 100.0) / total_requests, 0) AS error_rate, COALESCE(total_requests / %d, 0) AS throughput, @@ -35,7 +35,7 @@ SELECT FROM consumer_query ORDER BY - serviceName; + resource_string_service$$name; `, start, end, queueType, topic, partition, consumerGroup, timeRange) return query } @@ -48,14 +48,14 @@ WITH partition_query AS ( SELECT quantile(0.99)(durationNano) / 1000000 AS p99, count(*) AS total_requests, - stringTagMap['messaging.destination.name'] AS topic, - stringTagMap['messaging.destination.partition.id'] AS partition - FROM signoz_traces.distributed_signoz_index_v2 + attributes_string['messaging.destination.name'] AS topic, + attributes_string['messaging.destination.partition.id'] AS partition + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 4 - AND msgSystem = '%s' + AND attribute_string_messaging$$system = '%s' GROUP BY topic, partition ) @@ -78,25 +78,25 @@ func generateConsumerPartitionLatencySQL(start, end int64, topic, partition, que query := fmt.Sprintf(` WITH consumer_pl AS ( SELECT - stringTagMap['messaging.kafka.consumer.group'] AS consumer_group, - serviceName, + attributes_string['messaging.kafka.consumer.group'] AS consumer_group, + resource_string_service$$name, quantile(0.99)(durationNano) / 1000000 AS p99, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 5 - AND msgSystem = '%s' - AND stringTagMap['messaging.destination.name'] = '%s' - AND stringTagMap['messaging.destination.partition.id'] = '%s' - GROUP BY consumer_group, serviceName + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.destination.name'] = '%s' + AND attributes_string['messaging.destination.partition.id'] = '%s' + GROUP BY consumer_group, resource_string_service$$name ) SELECT consumer_group, - serviceName AS service_name, + resource_string_service$$name AS service_name, p99, COALESCE((error_count * 100.0) / total_requests, 0) AS error_rate, COALESCE(total_requests / %d, 0) AS throughput @@ -115,23 +115,23 @@ func generateProducerPartitionThroughputSQL(start, end int64, queueType string) query := fmt.Sprintf(` WITH producer_latency AS ( SELECT - serviceName, + resource_string_service$$name, quantile(0.99)(durationNano) / 1000000 AS p99, - stringTagMap['messaging.destination.name'] AS topic, + attributes_string['messaging.destination.name'] AS topic, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 4 - AND msgSystem = '%s' - GROUP BY topic, serviceName + AND attribute_string_messaging$$system = '%s' + GROUP BY topic, resource_string_service$$name ) SELECT topic, - serviceName AS service_name, + resource_string_service$$name AS service_name, p99, COALESCE((error_count * 100.0) / total_requests, 0) AS error_rate, COALESCE(total_requests / %d, 0) AS throughput @@ -148,17 +148,17 @@ func generateProducerTopicLatencySQL(start, end int64, topic, service, queueType WITH consumer_latency AS ( SELECT quantile(0.99)(durationNano) / 1000000 AS p99, - stringTagMap['messaging.destination.partition.id'] AS partition, + attributes_string['messaging.destination.partition.id'] AS partition, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 4 - AND serviceName = '%s' - AND msgSystem = '%s' - AND stringTagMap['messaging.destination.name'] = '%s' + AND resource_string_service$$name = '%s' + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.destination.name'] = '%s' GROUP BY partition ) @@ -179,24 +179,24 @@ func generateConsumerLatencySQL(start, end int64, queueType string) string { query := fmt.Sprintf(` WITH consumer_latency AS ( SELECT - serviceName, - stringTagMap['messaging.destination.name'] AS topic, + resource_string_service$$name, + attributes_string['messaging.destination.name'] AS topic, quantile(0.99)(durationNano) / 1000000 AS p99, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count, - SUM(numberTagMap['messaging.message.body.size']) AS total_bytes - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count, + SUM(attributes_number['messaging.message.body.size']) AS total_bytes + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 5 - AND msgSystem = '%s' - GROUP BY topic, serviceName + AND attribute_string_messaging$$system = '%s' + GROUP BY topic, resource_string_service$$name ) SELECT topic, - serviceName AS service_name, + resource_string_service$$name AS service_name, p99, COALESCE((error_count * 100.0) / total_requests, 0) AS error_rate, COALESCE(total_requests / %d, 0) AS ingestion_rate, @@ -216,17 +216,17 @@ func generateConsumerServiceLatencySQL(start, end int64, topic, service, queueTy WITH consumer_latency AS ( SELECT quantile(0.99)(durationNano) / 1000000 AS p99, - stringTagMap['messaging.destination.partition.id'] AS partition, + attributes_string['messaging.destination.partition.id'] AS partition, COUNT(*) AS total_requests, - sumIf(1, statusCode = 2) AS error_count - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 5 - AND serviceName = '%s' - AND msgSystem = '%s' - AND stringTagMap['messaging.destination.name'] = '%s' + AND resource_string_service$$name = '%s' + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.destination.name'] = '%s' GROUP BY partition ) @@ -246,26 +246,26 @@ func generateProducerConsumerEvalSQL(start, end int64, queueType string, evalTim query := fmt.Sprintf(` WITH trace_data AS ( SELECT - p.serviceName AS producer_service, - c.serviceName AS consumer_service, - p.traceID, + p.resource_string_service$$name AS producer_service, + c.resource_string_service$$name AS consumer_service, + p.trace_id, p.timestamp AS producer_timestamp, c.timestamp AS consumer_timestamp, p.durationNano AS durationNano, (toUnixTimestamp64Nano(c.timestamp) - toUnixTimestamp64Nano(p.timestamp)) + p.durationNano AS time_difference FROM - signoz_traces.distributed_signoz_index_v2 p + signoz_traces.distributed_signoz_index_v3 p INNER JOIN - signoz_traces.distributed_signoz_index_v2 c - ON p.traceID = c.traceID - AND c.parentSpanID = p.spanID + signoz_traces.distributed_signoz_index_v3 c + ON p.trace_id = c.trace_id + AND c.parent_span_id = p.span_id WHERE p.kind = 4 AND c.kind = 5 AND toUnixTimestamp64Nano(p.timestamp) BETWEEN '%d' AND '%d' AND toUnixTimestamp64Nano(c.timestamp) BETWEEN '%d' AND '%d' - AND c.msgSystem = '%s' - AND p.msgSystem = '%s' + AND c.attribute_string_messaging$$system = '%s' + AND p.attribute_string_messaging$$system = '%s' ) SELECT @@ -278,7 +278,7 @@ SELECT arrayMap(x -> x.1, arraySort( x -> -x.2, - groupArrayIf((traceID, time_difference), time_difference > '%d') + groupArrayIf((trace_id, time_difference), time_difference > '%d') ) ), 1, 10 @@ -296,30 +296,30 @@ func generateProducerSQL(start, end int64, topic, partition, queueType string) s query := fmt.Sprintf(` WITH producer_query AS ( SELECT - serviceName, + resource_string_service$$name, quantile(0.99)(durationNano) / 1000000 AS p99, count(*) AS total_count, - sumIf(1, statusCode = 2) AS error_count - FROM signoz_traces.distributed_signoz_index_v2 + sumIf(1, status_code = 2) AS error_count + FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 4 - AND msgSystem = '%s' - AND stringTagMap['messaging.destination.name'] = '%s' - AND stringTagMap['messaging.destination.partition.id'] = '%s' - GROUP BY serviceName + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.destination.name'] = '%s' + AND attributes_string['messaging.destination.partition.id'] = '%s' + GROUP BY resource_string_service$$name ) SELECT - serviceName AS service_name, + resource_string_service$$name AS service_name, p99, COALESCE((error_count * 100.0) / total_count, 0) AS error_percentage, COALESCE(total_count / %d, 0) AS throughput FROM producer_query ORDER BY - serviceName; + resource_string_service$$name; `, start, end, queueType, topic, partition, timeRange) return query } @@ -328,18 +328,18 @@ func generateNetworkLatencyThroughputSQL(start, end int64, consumerGroup, partit timeRange := (end - start) / 1000000000 query := fmt.Sprintf(` SELECT - stringTagMap['messaging.client_id'] AS client_id, - stringTagMap['service.instance.id'] AS service_instance_id, - serviceName AS service_name, + attributes_string['messaging.client_id'] AS client_id, + attributes_string['service.instance.id'] AS service_instance_id, + resource_string_service$$name AS service_name, count(*) / %d AS throughput -FROM signoz_traces.distributed_signoz_index_v2 +FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d' AND kind = 5 - AND msgSystem = '%s' - AND stringTagMap['messaging.kafka.consumer.group'] = '%s' - AND stringTagMap['messaging.destination.partition.id'] = '%s' + AND attribute_string_messaging$$system = '%s' + AND attributes_string['messaging.kafka.consumer.group'] = '%s' + AND attributes_string['messaging.destination.partition.id'] = '%s' GROUP BY service_name, client_id, service_instance_id ORDER BY throughput DESC `, timeRange, start, end, queueType, consumerGroup, partitionID) @@ -350,12 +350,12 @@ func onboardProducersSQL(start, end int64, queueType string) string { query := fmt.Sprintf(` SELECT COUNT(*) = 0 AS entries, - COUNT(IF(msgSystem = '%s', 1, NULL)) = 0 AS queue, + COUNT(IF(attribute_string_messaging$$system = '%s', 1, NULL)) = 0 AS queue, COUNT(IF(kind = 4, 1, NULL)) = 0 AS kind, - COUNT(IF(has(stringTagMap, 'messaging.destination.name'), 1, NULL)) = 0 AS destination, - COUNT(IF(has(stringTagMap, 'messaging.destination.partition.id'), 1, NULL)) = 0 AS partition + COUNT(IF(has(attributes_string, 'messaging.destination.name'), 1, NULL)) = 0 AS destination, + COUNT(IF(has(attributes_string, 'messaging.destination.partition.id'), 1, NULL)) = 0 AS partition FROM - signoz_traces.distributed_signoz_index_v2 + signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d';`, queueType, start, end) @@ -366,16 +366,16 @@ func onboardConsumerSQL(start, end int64, queueType string) string { query := fmt.Sprintf(` SELECT COUNT(*) = 0 AS entries, - COUNT(IF(msgSystem = '%s', 1, NULL)) = 0 AS queue, + COUNT(IF(attribute_string_messaging$$system = '%s', 1, NULL)) = 0 AS queue, COUNT(IF(kind = 5, 1, NULL)) = 0 AS kind, - COUNT(serviceName) = 0 AS svc, - COUNT(IF(has(stringTagMap, 'messaging.destination.name'), 1, NULL)) = 0 AS destination, - COUNT(IF(has(stringTagMap, 'messaging.destination.partition.id'), 1, NULL)) = 0 AS partition, - COUNT(IF(has(stringTagMap, 'messaging.kafka.consumer.group'), 1, NULL)) = 0 AS cgroup, - COUNT(IF(has(numberTagMap, 'messaging.message.body.size'), 1, NULL)) = 0 AS bodysize, - COUNT(IF(has(stringTagMap, 'messaging.client_id'), 1, NULL)) = 0 AS clientid, - COUNT(IF(has(stringTagMap, 'service.instance.id'), 1, NULL)) = 0 AS instanceid -FROM signoz_traces.distributed_signoz_index_v2 + COUNT(resource_string_service$$name) = 0 AS svc, + COUNT(IF(has(attributes_string, 'messaging.destination.name'), 1, NULL)) = 0 AS destination, + COUNT(IF(has(attributes_string, 'messaging.destination.partition.id'), 1, NULL)) = 0 AS partition, + COUNT(IF(has(attributes_string, 'messaging.kafka.consumer.group'), 1, NULL)) = 0 AS cgroup, + COUNT(IF(has(attributes_number, 'messaging.message.body.size'), 1, NULL)) = 0 AS bodysize, + COUNT(IF(has(attributes_string, 'messaging.client_id'), 1, NULL)) = 0 AS clientid, + COUNT(IF(has(attributes_string, 'service.instance.id'), 1, NULL)) = 0 AS instanceid +FROM signoz_traces.distributed_signoz_index_v3 WHERE timestamp >= '%d' AND timestamp <= '%d';`, queueType, start, end) diff --git a/pkg/query-service/constants/constants.go b/pkg/query-service/constants/constants.go index 7d6f087188..33caecb0d6 100644 --- a/pkg/query-service/constants/constants.go +++ b/pkg/query-service/constants/constants.go @@ -90,7 +90,7 @@ func EnableHostsInfraMonitoring() bool { return GetOrDefaultEnv("ENABLE_INFRA_METRICS", "true") == "true" } -var KafkaSpanEval = GetOrDefaultEnv("KAFKA_SPAN_EVAL", "false") +var KafkaSpanEval = GetOrDefaultEnv("KAFKA_SPAN_EVAL", "true") func IsDurationSortFeatureEnabled() bool { isDurationSortFeatureEnabledStr := DurationSortFeature diff --git a/sample-apps/hotrod/README.md b/sample-apps/hotrod/README.md index b9638281a0..3498a06bd4 100644 --- a/sample-apps/hotrod/README.md +++ b/sample-apps/hotrod/README.md @@ -5,7 +5,7 @@ Follow the steps in this section to install a sample application named HotR.O.D, ```console kubectl create ns sample-application -kubectl -n sample-application apply -f https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod.yaml +kubectl -n sample-application apply -f https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod.yaml ``` In case, you have installed SigNoz in namespace other than `platform` or selected Helm release name other than `my-release`, follow the steps below: @@ -15,7 +15,7 @@ export HELM_RELEASE=my-release-2 export SIGNOZ_NAMESPACE=platform-2 export HOTROD_NAMESPACE=sample-application-2 -curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-install.sh | bash +curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-install.sh | bash ``` To delete sample application: @@ -23,7 +23,7 @@ To delete sample application: ```console export HOTROD_NAMESPACE=sample-application-2 -curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-delete.sh | bash +curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-delete.sh | bash ``` For testing with local scripts, you can use the following commands: diff --git a/sample-apps/hotrod/hotrod-delete.sh b/sample-apps/hotrod/hotrod-delete.sh index 9cc50b4d52..a7d88ebc07 100755 --- a/sample-apps/hotrod/hotrod-delete.sh +++ b/sample-apps/hotrod/hotrod-delete.sh @@ -7,7 +7,7 @@ HOTROD_NAMESPACE=${HOTROD_NAMESPACE:-"sample-application"} if [[ "${HOTROD_NAMESPACE}" == "default" || "${HOTROD_NAMESPACE}" == "kube-system" || "${HOTROD_NAMESPACE}" == "platform" ]]; then echo "Default k8s namespace and SigNoz namespace must not be deleted" echo "Deleting components only" - kubectl delete --namespace="${HOTROD_NAMESPACE}" -f <(cat hotrod-template.yaml || curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-template.yaml) + kubectl delete --namespace="${HOTROD_NAMESPACE}" -f <(cat hotrod-template.yaml || curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-template.yaml) else echo "Delete HotROD sample app namespace ${HOTROD_NAMESPACE}" kubectl delete namespace "${HOTROD_NAMESPACE}" diff --git a/sample-apps/hotrod/hotrod-install.sh b/sample-apps/hotrod/hotrod-install.sh index 42f29ede5f..b7ba4f6caa 100755 --- a/sample-apps/hotrod/hotrod-install.sh +++ b/sample-apps/hotrod/hotrod-install.sh @@ -37,7 +37,7 @@ kubectl create namespace "$HOTROD_NAMESPACE" --save-config --dry-run -o yaml 2>/ # Setup sample apps into specified namespace kubectl apply --namespace="${HOTROD_NAMESPACE}" -f <( \ - (cat hotrod-template.yaml 2>/dev/null || curl -sL https://github.com/SigNoz/signoz/raw/develop/sample-apps/hotrod/hotrod-template.yaml) | \ + (cat hotrod-template.yaml 2>/dev/null || curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-template.yaml) | \ HOTROD_NAMESPACE="${HOTROD_NAMESPACE}" \ HOTROD_IMAGE="${HOTROD_IMAGE}" \ LOCUST_IMAGE="${LOCUST_IMAGE}" \