Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

[6.1.0] Lost cookies in Firebase cloud function #746

Closed
hanh090 opened this issue Mar 1, 2023 · 6 comments
Closed

[6.1.0] Lost cookies in Firebase cloud function #746

hanh090 opened this issue Mar 1, 2023 · 6 comments
Labels

Comments

@hanh090
Copy link

hanh090 commented Mar 1, 2023

Issue summary

I am using Shopify CLI 3.44.1 to build Shopify App. I am using a embedded app. It was trimmed the cookies from Shopify which leads to failed authorize step

Already tried out some solution suggested in #686

App failed to authorize Screenshot 2023-03-01 at 10 13 29
Cookies there but shopify Screenshot 2023-03-01 at 10 13 37
  • @shopify/shopify-api version: 6.1.0
  • Node version: 14
  • Operating system: macos

Expected behavior

The cookies should be visible

Actual behavior

Only the cookies from Shopify was removed, others work

@hacthe-codelink
Copy link

Have you been able to solve the problems yet a? Please give me some advice @@ I have met this problem too.

@ploiid10
Copy link

Hi @hanh090 this is because of firebase hosting. Firebase hosting strips off all the cookies and only retains _session cookies if I am not mistaken. You need to create a fork and update it then and refer to this example 663770d#diff-6d51b2183d0c222edade683487a367f119f7fc23a28dce1c9c19f12e4cea2e3f

@ploiid10
Copy link

Hi @hanh090 this is because of firebase hosting. Firebase hosting strips off all the cookies and only retains _session cookies if I am not mistaken. You need to create a fork and update it then and refer to this example 663770d#diff-6d51b2183d0c222edade683487a367f119f7fc23a28dce1c9c19f12e4cea2e3f

@hacthe-codelink ☝️

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label May 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as completed Jun 6, 2023
@hanh090
Copy link
Author

hanh090 commented Aug 9, 2023

@hacthe-codelink the problem is prefix in shopify cookies, it must matching with firebase domain config

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants