-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected]: Add manifest #6374
base: master
Are you sure you want to change the base?
Conversation
/verify |
All changes look good. Wait for review from human collaborators. mise
|
1 similar comment
All changes look good. Wait for review from human collaborators. mise
|
I am trying to do the right thing with the PR title, but the documentation is contradicting.
|
If we want mise to be purged if {
"post_uninstall": [
"if ($purge) {",
" $Directories = [string[]](",
" ('{0}\\mise' -f $env:LOCALAPPDATA),",
" ('{0}\\Temp\\mise' -f $env:LOCALAPPDATA)",
" )",
" $Directories.ForEach{",
" if (Test-Path -Path $_ -PathType 'Container') {",
" $null = Remove-Item -Path $_ -Recurse -Force",
" }",
" }",
"}"
]
} |
I was about to submit a PR; thanks @FilipDeVos! I suggest two things:
|
I noticed that we need to add $env:LOCALAPPDATA\mise\shims to $env:PATH I'll research a bit what the best way of doing this is. |
Scratch this ideaMaybe "post_install" to add it with PowerShell, and "post_uninstall" to remove it? In user context. Something like this (untested): [System.Environment]::SetEnvironmentVariable(
'Path',
('{0};{1}\mise\shims' -f [System.Environment]::GetEnvironmentVariable('Path','User'), $env:LOCALAPPDATA),
'User'
) Edit: Scratch the above, seems Scoop has |
env_add_path only supports folders under the installation folder I think. |
I think this commit does the trick. |
/verify |
Your changes do not pass checks. mise-en-place
|
/verify |
All changes look good. Wait for review from human collaborators. mise-en-place
|
@FilipDeVos thank you so much for doing this, I was literally starting to do it myself when I thought to check if maybe someone made a PR already. It's great you added the shims, though in the future if we get powershell support for I am also working on winget (though it's failing and idk why) and have created a github action to automatically bump it on releases. Do you think something similar for scoop would be good? I know these are unrelated to scoop but we also have chocolatey which is community maintained, but I have noticed it has been quite out of date. I think if you or I did some of the legwork on automatically bumping in gha it would probably be good to try to knock out all 3. |
@jdx scoop auto-updates the version, that is what the checkver logic is for. So there is no need to make pipelines. Once the PR is merged in main it will start bumping the version automatically. I can take a look at the winget/chocolatey Manifests if you have a branch somewhere, but I'm not interested in being maintainer of that stuff. |
totally understand, if you wouldn't mind having a look at my winget PR to see if there is anything obviously wrong I would definitely appreciate it! |
The name |
There's no contradicting,
|
No matches found. |
It has not been merged yet. |
This pull request adds the manifest to install the "mise-en-place" tool from https://github.com/jdx/mise/
Closes #6329
<manifest-name[@version]|chore>: <general summary of the pull request>