Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: Fix 'winsymlink' error #6335

Merged
merged 1 commit into from
Nov 22, 2024
Merged

podman: Fix 'winsymlink' error #6335

merged 1 commit into from
Nov 22, 2024

Conversation

niheaven
Copy link
Member

The change in filePath.EvalSymlinks() behavior in Go 1.23 has resulted in Podman versions after 5.3.0 being unable to locate win-sshagent.exe. Temporary fix refer to containers/podman#24557 (comment).

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

podman

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@niheaven niheaven merged commit 20ad69b into master Nov 22, 2024
5 checks passed
@niheaven niheaven deleted the fix-podman branch November 22, 2024 06:43
@gebinic
Copy link

gebinic commented Nov 27, 2024

I ran scoop install podman and got the following log:

Installing 'podman' (5.3.1) [64bit] from 'main' bucket
podman-5.3.1-setup.exe (30,5 MB) [=============================================================================================================================================================] 100%
Checking hash of podman-5.3.1-setup.exe ... ok.
Running installer script...Adding ~\scoop\apps\podman\5.3.1 to your path.
done.
Installer added '~\scoop\apps\podman\5.3.1' to path. Removing.
Linking ~\scoop\apps\podman\current => ~\scoop\apps\podman\5.3.1
Creating shim for 'podman'.
'podman' (5.3.1) was installed successfully!

The PATH environment variable does not contain the path ~\scoop\apps\podman\5.3.1 either.

EDIT:
I did some additional testing and found out that after installing an app, scoop always removes the directory of the versioned app from the PATH environment variable (see https://github.com/ScoopInstaller/Scoop/blob/859d1db51bcc840903d5280567846ae2f7207ca2/lib/install.ps1#L57 and https://github.com/ScoopInstaller/Scoop/blob/859d1db51bcc840903d5280567846ae2f7207ca2/lib/install.ps1#L849). The versioned app directory is e.g. ~\scoop\apps\podman\5.3.1. If I enable the isolated path with scoop config use_isolated_path true and run scoop install podman (after uninstalling it first!), it seems to work.

@niheaven
Copy link
Member Author

I'll check Scoop Core's code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Podman v5.3.0, when installed via scoop, produces an error when running podman machine start
2 participants