Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop converting null string arguments into empty strings #334

Open
ChrisThrasher opened this issue Sep 16, 2024 · 0 comments
Open

Stop converting null string arguments into empty strings #334

ChrisThrasher opened this issue Sep 16, 2024 · 0 comments

Comments

@ChrisThrasher
Copy link
Member

Some APIs check will convert null const char* arguments to an empty string. I propose CSFML stop doing this except where the API actually promises that the behavior of null arguments is defined.

For example:

sfFtpResponse* sfFtp_login(sfFtp* ftp, const char* name, const char* password)
{
assert(ftp);
return new sfFtpResponse{ftp->This.login(name ? name : "", password ? password : "")};
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant