Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce vectorcall specialization for Python call API. #4656

Open
Icxolu opened this issue Oct 26, 2024 · 0 comments · May be fixed by #4768
Open

Reintroduce vectorcall specialization for Python call API. #4656

Icxolu opened this issue Oct 26, 2024 · 0 comments · May be fixed by #4768
Labels
performance
Milestone
0.24

Comments

@Icxolu
Copy link
Contributor

Icxolu commented Oct 26, 2024

As part of the IntoPyObject migration process we removed the vectorcall optimization for simplicity for now in #4653. It was added in #4456 to speed up Python's call API by using the vectorcall calling convention where possible. This optimization was build on top of IntoPy which will be deprecated now in favor of IntoPyObject (#4618).

We'd like to reintroduce it in a future version using a separate PyCallArgs trait as discussed in #4456 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
0.24
Development

Successfully merging a pull request may close this issue.

reintroduce vectorcall optimization with new PyCallArgs trait Icxolu/pyo3
2 participants
@davidhewitt @Icxolu