Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time crate in addition to chrono for datetime types. #4675

Open
avhz opened this issue Oct 31, 2024 · 2 comments
Open

Support time crate in addition to chrono for datetime types. #4675

avhz opened this issue Oct 31, 2024 · 2 comments

Comments

@avhz
Copy link

avhz commented Oct 31, 2024

Would it be possible to support the time crate in addition to the currently supported chrono crate ?

It is very widely used (time: 292m downloads, chrono: 214m downloads), so I think it makes sense to support both, since many crates use it for their date/time stuff.

I would personally use it myself, and I am willing to impl the necessary traits when I get some time if you are open to a PR for it :)

@davidhewitt
Copy link
Member

I think there is good justification for time support, yes.

@avhz
Copy link
Author

avhz commented Nov 1, 2024

Awesome :) I spent a bit of time writing a draft PR (#4677), basically just copying your chrono implementation.

Will finalise it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants