import statements should be after any shebang line

[daira]

+from __future__ import print_function
 #!/usr/bin/env python

Imports should only be added after any initial lines that are either blank or start with #. That would account for copyright headers etc., as well as shebang lines.

(moved from mitsuhiko/python-modernize#21 )

[daira]

Taking into account #19, an import of a module that is not already imported at top-level should go:

• after existing __future__ imports, if any
• otherwise, after the module docstring, if any
• otherwise, after any initial lines that are either blank or start with #.

[daira]

(A module docstring is defined as a string at top-level that precedes any other code.)

[daira]

This only affects scripts; it can wait until the next release.

[techtonik]

I would say that this can be simplified to "just before any real Python code that is not merely a string".

[daira]

No, because of #19; I originally filed #19 because of such a case in Tahoe-LAFS.

[takluyver]

I think the ordering should be:

1. Shebang
2. Encoding comment
3. Module docstring
4. __future__ imports
5. Regular imports
6. General code

And any combination of the above can be omitted. I think the tricky thing is that it tries to add new imports at the end of the imports block, and that can go wrong if people mix other bits of code into their imports.

[techtonik]

@daira don't treat unicode strings as "merely a string" and that's it.

[daira]

mitsuhiko/python-modernize#30 was a duplicate (see also django-wiki/django-wiki#33 ).