Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "L2tpPsk" from the history #4077

Open
1 task done
exchange12rocks opened this issue Jul 17, 2024 · 0 comments
Open
1 task done

Remove "L2tpPsk" from the history #4077

exchange12rocks opened this issue Jul 17, 2024 · 0 comments
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.

Comments

@exchange12rocks
Copy link

exchange12rocks commented Jul 17, 2024

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

Cmdlets Add-VpnConnection, Set-VpnConnection have a parameter -L2tpPsk that contains a secret key shared between the server and the client. I suppose this is a sensitive information and its worth to filter out commands that have this parameter with a clear-text value.

Proposed technical implementation details (optional)

Add "L2tpPsk" into the list https://github.com/PowerShell/PSReadLine/blob/master/PSReadLine/History.cs#L117

@exchange12rocks exchange12rocks added the Issue-Enhancement It's a feature request. label Jul 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.
Projects
None yet
Development

No branches or pull requests

1 participant