-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prql-query formula doesn't work on Linux atm #8
Comments
I'm happy to take another look at this but I'm very confused about what's actually going on. I think your first comment linked to this run (https://github.com/prql/homebrew-prql/actions/runs/3316049427/jobs/5477387112) and while it was triggered by a prql-query PR, it seemed to be the prql-compiler test that was failing. I'm not sure if I'm reading the output correctly but it seemed to not be able to find Anyway, your current job which disabled the prql-query tests seems to be doing well (it seems to have passed on linux and atm is building the macos one). If I can find some error messages to what the prql-query builds are failing on, then I could try and debug. If your build passes then maybe I can do it in a separate PR. I think installing the binaries rather than building would be much better. I tried out the Any idea of how to go about that though? |
The latest failure was https://github.com/prql/homebrew-prql/actions/runs/3323612657/jobs/5494180690#step:6:29 |
Yes, very much agree. I'm not sure, but I expect there are lots of examples of this out there — lots of rust tools like |
Great idea. I had a look at the ripgrep formula: https://github.com/Homebrew/homebrew-core/blob/master/Formula/ripgrep.rb Which pointed me at bottles which seems to be the homebrew term for binaries: https://docs.brew.sh/Bottles Interestingly prql-compiler is already bottled: https://github.com/Homebrew/homebrew-core/blob/master/Formula/prql-compiler.rb Were you aware of this? My guess from reading the old prql-compiler homebrew issues is that when prql-compiler got accepted into homebrew-core, some volunteers on their side picked it up and set up all the plumbing to do the bottling. This post gives more guidance: https://jonathanchang.org/blog/maintain-your-own-homebrew-repository-with-binary-bottles/ It all looks a bit too involved for me right now though. I feel like my best bet at this point might just be to rather make prql-query more useful and then hope that on the back of the appeal of PRQL and pq's usefulness it gets accepted into homebrew-core and some kind soul does the bottling for us. What do you think? |
Yes! I didn't know it was bottled. There is an issue to set up an mechanism to update it on new releases, and change our docs to point to it.
No verdict on what you should work on — whatever you think will inspire you :) In terms of making it a successful project — if you're asking for my opinion — I do think we want some reasonable way for people to try Given that it's CLI-based, people are probably going to be OK with It's such a strong initial tool that I expect getting a few users won't be difficult, assuming we can find a catchy way of showing it (I'm already using it to replace my use of I do think — both for WDYT? I'm keen to be helpful, both to be helpful to you personally and because I think |
FYI @snth; I had a go in #7, but couldn't get it working after a couple of tries, and really that dependency should be added to the formula.
Another approach would be to install the binary rather than compile it — a bit more work, but much faster for the consumer.
(or fine to not support linux, but I would vote to explicitly fail...)
The text was updated successfully, but these errors were encountered: