Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Session Button not visible #127

Open
abarya opened this issue Sep 20, 2017 · 4 comments
Open

Request Session Button not visible #127

abarya opened this issue Sep 20, 2017 · 4 comments

Comments

@abarya
Copy link
Contributor

abarya commented Sep 20, 2017

Using chrome, if I open the request session webpage, then the request session button in the typeform is not clearly visible. I'm also attaching a screenshot.

FYI, it works fine in firefox.

image

@vaibhavsingh97
Copy link
Member

@abhishekarya286 Can you please fix it and send a PR 😄

@abarya
Copy link
Contributor Author

abarya commented Sep 20, 2017

Actually, the way I tried to do this was by changing the height of the typeform to 80%. Is it fine, @vaibhavsingh97?

@anubhakushwaha
Copy link
Member

@abhishekarya286 Are you able to reproduce it again? Because ideally it should not have happened as width and height occupy the whole container. Incase you do please help us in fixing this.

@Nickatak
Copy link
Contributor

Nickatak commented Jan 11, 2018

Hello! Sorry if this is a little unclear (first time adding anything to a bug).

I was able to duplicate the error with the development server by following these steps:

  • Initial setup (installing requirements/migrating/etc.)
  • Opening the page (Request a session under url pattern '/session/' that calls request_session from views) with chrome using version 63.0.3239.132 on a Windows-box (10, x64).
  • Grabbing the lower part of the browser and moving it upward (the error itself will still show regardless of the browser's width).

The same steps above (minus the initial setup) also reproduce the error on the master branch's deployed site.

Based on initial testing, it looks like the problem is that the button itself and the welcome text do not scale with the webpage, while the image does. This error occurs when the height of the image + height of the button (static) + height of the welcome text (also static) > the overall height of the containing window (the iframe) designated by:

<iframe id="typeform-full" width="100%" height="100%" frameborder="0" src="https://oshc.typeform.com/to/CvcyEy"></iframe>

  • Example 1: In the image below, you can see a nearly max-width browser (2k) shrunken vertically displaying the issue depicted.
    image

  • Example 2: In the image below, you can see a vertically and horizontally shrunken browser displaying the issue depicted.
    image

Edits: Clarity/wording/information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants