Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OMPD] The LLVM OMPD ompd_get_task_in_parallel() function misspells "ompd_nvptx_parallel_info_t" #64

Open
jdelsign opened this issue Feb 27, 2019 · 0 comments
Open

[OMPD] The LLVM OMPD ompd_get_task_in_parallel() function misspells "ompd_nvptx_parallel_info_t" #64

jdelsign opened this issue Feb 27, 2019 · 0 comments
Labels
fixed in ompd-devices-50

Comments

@jdelsign
Copy link

The LLVM OMPD ompd_get_task_in_parallel() function has a typo in the CUDA device code. It misspells "ompd_nvptx_parallel_info_t" as "ompd_nvptx_paralel_info". Diff to fix it follows:

  -------------------------- libompd/src/omp-debug.cpp --------------------------
  index fae2b63..8e9b645 100644
  @@ -865,7 +865,7 @@ ompd_rc_t ompd_get_task_in_parallel(

     if (parallel_handle->ah->kind == OMPD_DEVICE_KIND_CUDA) {
       ret = TValue(context, parallel_handle->th)
  -              .cast("ompd_nvptx_paralel_info", 0,
  +              .cast("ompd_nvptx_parallel_info_t", 0,
		       OMPD_SEGMENT_CUDA_PTX_GLOBAL)
		 .access("parallel_tasks")
		 .cast("omptarget_nvptx_TaskDescr", 1,
jdelsign added a commit that referenced this issue Apr 25, 2019
@jdelsign
Fixes to work with TotalView.
df2be0b 
* Corrected the fix for issue: [OMPD] The LLVM OMPD
  ompd_get_api_version() function returns a non-standard API version.
  #51
  - Define OMPD_VERSION as 201811.
  - Define OMPD_DLL_VERSION to what used to be defined as OMPD_VERSION.

* Fixed issue: [OMPD] The LLVM OMPD ompd_get_task_in_parallel()
  function misspells "ompd_nvptx_parallel_info_t".  It was marked a
  being fixed by Manoel on March 26, 2019, but AFAICT the fix is not
  in the ompd-device-50 branch sources.
  #64
  - Change "ompd_nvptx_paralel_info" to "ompd_nvptx_parallel_info_t".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed in ompd-devices-50
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manorom @jdelsign