Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server implementation doesn't set range end for textDocument/definition #269

Open
mickaelistria opened this issue Jul 27, 2016 · 2 comments

Comments

@mickaelistria
Copy link

I'm invoking textDocument/definition. The returned range starts correctly, however the end isn't set. The expectation would be in this case that the range gets to the last character of the variable name.
The issue seems to be that the underlying /gotodefinition operation from the server doesn't return and end position nor a length.

@david-driscoll
Copy link
Member

Right now the server doesn't have any the span of the definition (something we will have to add eventually).

Are you not getting any end position back? Or is it just the same as the start position? (Right now it should be the same position for both).

To get the proper end position we'll have to add that to the server resposne.

@mickaelistria
Copy link
Author

mickaelistria commented Jul 27, 2016

Are you not getting any end position back?

No end position at all (which is better than a wrong end position)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants