-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Kulture and OmniSharpSublime #12
Comments
I was thinking yesterday, that the server should return the list of 'k' commands to run from the project.json file. |
We spoke about this before and I said at the time that not everyone who uses omnisharp would use Kulture.... but it seems like a small change to add to the server and we're gonna need it for the other editors. |
Sounds good, I'm all for it. I think that is the best course of action. |
What do you guys think are the next steps for merging? Would now be a good time to have another call? |
Might want to speak to @davidfowl about this too. OmniSharp/omnisharp-roslyn#22 |
Hey there, do you already have somewhere an exhaustive list of the features to merge into OmniSharpSublime ? I will have a look at the source code for now but I think I can spend time on this. |
I don't have a list maybe @sayedihashimi does. There is a PR here that needs fixing on the server which will expose the |
I think the main things that we need are exposing the k commands and project.json intellisense. project.json intellisense should be done on the server I think to make it easier for the other editors to integrate. |
@cubitouch We hang out in https://jabbr.net/#/rooms/omnisharp if you want to drop by and chat :) |
Ok, will try to have a look at this PR. |
I think in time we should move this into OmniSharpSublime.
My current thought is OmniSharpSublime will need to detect whether its working on a vNext project or a traditional solution project ie. it searches for project.json
Based on the search this will enable/disable certain features of the plugin suitable for traditional/vNext projects.
Anyway thats my brain dump but just thought I'd tentatively open this issue for discussion.
The text was updated successfully, but these errors were encountered: