Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Kulture and OmniSharpSublime #12

Open
jchannon opened this issue Dec 2, 2014 · 10 comments
Open

Merge Kulture and OmniSharpSublime #12

jchannon opened this issue Dec 2, 2014 · 10 comments

Comments

@jchannon
Copy link
Member

jchannon commented Dec 2, 2014

I think in time we should move this into OmniSharpSublime.

My current thought is OmniSharpSublime will need to detect whether its working on a vNext project or a traditional solution project ie. it searches for project.json

Based on the search this will enable/disable certain features of the plugin suitable for traditional/vNext projects.

Anyway thats my brain dump but just thought I'd tentatively open this issue for discussion.

@nosami
Copy link

nosami commented Dec 2, 2014

I was thinking yesterday, that the server should return the list of 'k' commands to run from the project.json file.

@nosami
Copy link

nosami commented Dec 2, 2014

We spoke about this before and I said at the time that not everyone who uses omnisharp would use Kulture.... but it seems like a small change to add to the server and we're gonna need it for the other editors.

@sayedihashimi
Copy link
Member

Sounds good, I'm all for it. I think that is the best course of action.

@sayedihashimi
Copy link
Member

What do you guys think are the next steps for merging? Would now be a good time to have another call?

@nosami
Copy link

nosami commented Dec 18, 2014

Might want to speak to @davidfowl about this too. OmniSharp/omnisharp-roslyn#22

@cubitouch
Copy link

Hey there, do you already have somewhere an exhaustive list of the features to merge into OmniSharpSublime ? I will have a look at the source code for now but I think I can spend time on this.

@jchannon
Copy link
Member Author

I don't have a list maybe @sayedihashimi does. There is a PR here that needs fixing on the server which will expose the k commands for the project which editors can use OmniSharp/omnisharp-roslyn#67

@nosami
Copy link

nosami commented Feb 12, 2015

I think the main things that we need are exposing the k commands and project.json intellisense. project.json intellisense should be done on the server I think to make it easier for the other editors to integrate.

@nosami
Copy link

nosami commented Feb 12, 2015

@cubitouch We hang out in https://jabbr.net/#/rooms/omnisharp if you want to drop by and chat :)

@cubitouch
Copy link

Ok, will try to have a look at this PR.
@nosami I can not come now, but I will try in few hours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants